From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Stringer Subject: Re: [PATCHv2 net 1/2] fm10k: Check tunnel header length in encap offload Date: Thu, 13 Nov 2014 16:54:19 -0800 Message-ID: <201411131654.19998.joestringer@nicira.com> References: <1415921801-10452-1-git-send-email-joestringer@nicira.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: "netdev@vger.kernel.org" , "Kirsher, Jeffrey T" , Linux NICS , "therbert@google.com" , "gerlitz.or@gmail.com" , "alexander.duyck@gmail.com" , "linux-kernel@vger.kernel.org" To: "Vick, Matthew" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thursday, November 13, 2014 16:41:03 Vick, Matthew wrote: > On 11/13/14, 3:36 PM, "Joe Stringer" wrote: > >fm10k supports up to 184 bytes of inner+outer headers. Add an initial > >check to fail encap offload if these are too large. > > > >Signed-off-by: Joe Stringer > >--- > >Matthew, I didn't see the equivalent patch on netdev so I went ahead and > >created it. If I've missed this somewhere, then please disregard. > > > >v2: First post. > > You didn't miss it Joe--it just hasn't made it up yet. :) It's currently > in Jeff's tree for testing. You're on the CC for the patch, so you'll get > a notification once it goes up. It's basically the same as what you have, > except the #define I use is 184 and I use inner_tcp_hdrlen() to account > for the inner TCP header length. > > Since your second patch should apply cleanly on top of mine, what do you > think about dropping the first patch in this series and Jeff can send our > two patches up together once they've passed testing? Ah, that sounds great. Cheers, Joe