From: "John W. Linville" <linville@tuxdriver.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: netdev <netdev@vger.kernel.org>,
Dave Miller <davem@davemloft.net>,
Auke Kok <auke-jan.h.kok@intel.com>,
Malli Chilakala <mallikarjuna.chilakala@intel.com>
Subject: Re: [PATCH] e100: fix typo in MDI/MDI-X eeprom check in e100_phy_init
Date: Fri, 14 Nov 2014 12:58:28 -0500 [thread overview]
Message-ID: <20141114175828.GD1893@tuxdriver.com> (raw)
In-Reply-To: <CAL3LdT5yEg1MqDyigzFpfPkpFv8ST09uPYSEwqaKAypEvDwHeQ@mail.gmail.com>
On Fri, Nov 14, 2014 at 09:17:39AM -0800, Jeff Kirsher wrote:
> On Fri, Nov 14, 2014 at 7:59 AM, John W. Linville
> <linville@tuxdriver.com> wrote:
> > Although it doesn't explicitly say so, commit 60ffa478759f39a2 ("e100:
> > Fix MDIO/MDIO-X") appears to be intended to revert the earlier commit
> > 648951451e6d2d53 ("e100: fixed e100 MDI/MDI-X issues"). However,
> > careful examination reveals that the attempted revert actually
> > _inverted_ the test for eeprom_mdix_enabled. That is bound to program
> > a few PHYs incorrectly...
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=1156417
> >
> > Signed-off-by: John W. Linville <linville@tuxdriver.com>
> > Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> > Cc: Auke Kok <auke-jan.h.kok@intel.com>
> > Cc: Malli Chilakala <mallikarjuna.chilakala@intel.com>
> > ---
> > Wow, an 8 year old bug in e100 -- woohoo!! :-)
> >
> > This was causing some serious flakiness for a large cash register
> > deployment in Europe. Testing with this one-line (really,
> > one-character) patch seems to have resolved the issue.
> >
> > drivers/net/ethernet/intel/e100.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Weird, I did not get this mail. Anyway, thanks John, I have added
> your patch to my queue.
I got a "no such address" bounce on all the @intel.com addresses,
but they all seem OK to me -- not sure what the issue is...?
Anyway, glad you got it! :-)
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2014-11-14 18:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 15:59 [PATCH] e100: fix typo in MDI/MDI-X eeprom check in e100_phy_init John W. Linville
2014-11-14 17:17 ` Jeff Kirsher
2014-11-14 17:58 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141114175828.GD1893@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=auke-jan.h.kok@intel.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=mallikarjuna.chilakala@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).