Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: anish@chelsio.com
Cc: netdev@vger.kernel.org, john.fastabend@gmail.com,
	neerav.parikh@intel.com
Subject: Re: [PATCH net] dcbnl : Disable software interrupts before taking dcb_lock
Date: Sun, 16 Nov 2014 14:51:26 -0500 (EST)	[thread overview]
Message-ID: <20141116.145126.191966834846491028.davem@davemloft.net> (raw)
In-Reply-To: <1416011911-28998-1-git-send-email-anish@chelsio.com>

From: Anish Bhatt <anish@chelsio.com>
Date: Fri, 14 Nov 2014 16:38:31 -0800

> Solves possible lockup issues that can be seen from firmware DCB agents calling
> into the DCB app api.
> 
> DCB firmware event queues can be tied in with NAPI so that dcb events are
> generated in softIRQ context. This can results in calls to dcb_*app()
> functions which try to take the dcb_lock.
> 
> If the the event triggers while we also have the dcb_lock because lldpad or
> some other agent happened to be issuing a  get/set command we could see a cpu
> lockup.
> 
> This code was not originally written with firmware agents in mind, hence
> grabbing dcb_lock from softIRQ context was not considered.
> 
> Signed-off-by: Anish Bhatt <anish@chelsio.com>

Applied, thanks.

      reply	other threads:[~2014-11-16 19:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-15  0:38 [PATCH net] dcbnl : Disable software interrupts before taking dcb_lock Anish Bhatt
2014-11-16 19:51 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141116.145126.191966834846491028.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=anish@chelsio.com \
    --cc=john.fastabend@gmail.com \
    --cc=neerav.parikh@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox