From: Thomas Graf <tgraf@suug.ch>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Josh Triplett <josh@joshtriplett.org>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
paulmck@linux.vnet.ibm.com
Subject: Re: [PATCH 4/4] rhashtable: Add parent argument to mutex_is_held
Date: Mon, 17 Nov 2014 06:16:54 +0000 [thread overview]
Message-ID: <20141117061654.GA8723@casper.infradead.org> (raw)
In-Reply-To: <20141117044657.GA30723@gondor.apana.org.au>
On 11/17/14 at 12:46pm, Herbert Xu wrote:
> On Sat, Nov 15, 2014 at 06:37:26PM -0800, Josh Triplett wrote:
> > On November 15, 2014 6:22:27 PM PST, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> > >Josh Triplett <josh@joshtriplett.org> wrote:
> > >>
> > >> - Set up the new empty table with the new set of hash parameters.
> > >> - synchronize_rcu(). Readers will now search both old and new
> > >tables.
> > >> - Peel nodes off the ends of the old hash table and add them to the
> > >new
> > >
> > >We currently use a singly linked list in rhashtable. Peeling nodes
> > >off the end would mean upgrading to a doubly linked list, which is
> > >no different than keeping two lists in terms of cache footprint, no?
> >
> > No, since each pass just handles one set of nodes from each bucket anyway, you can just do a bit more work in the rehasher instead.
>
> OK let me see if I could implement something like that in rhashtable.
This sounds great. Thanks Herbert and Josh!
next prev parent reply other threads:[~2014-11-17 6:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 10:10 [PATCH 0/4] rhashtable: Allow local locks to be used and tested Herbert Xu
2014-11-13 10:11 ` [PATCH 1/4] netlink: Move mutex_is_held under PROVE_LOCKING Herbert Xu
2014-11-13 10:11 ` [PATCH 2/4] netfilter: " Herbert Xu
2014-11-13 10:11 ` [PATCH 3/4] rhashtable: " Herbert Xu
2014-11-13 10:11 ` [PATCH 4/4] rhashtable: Add parent argument to mutex_is_held Herbert Xu
2014-11-13 10:37 ` Thomas Graf
2014-11-13 10:38 ` Herbert Xu
2014-11-13 10:41 ` Thomas Graf
2014-11-13 10:43 ` Herbert Xu
2014-11-15 3:25 ` Herbert Xu
2014-11-15 11:16 ` Thomas Graf
2014-11-15 11:23 ` Herbert Xu
2014-11-15 15:51 ` Herbert Xu
2014-11-17 6:20 ` Thomas Graf
2014-11-15 19:12 ` Josh Triplett
2014-11-16 2:22 ` Herbert Xu
2014-11-16 2:37 ` Josh Triplett
2014-11-17 4:46 ` Herbert Xu
2014-11-17 6:16 ` Thomas Graf [this message]
2014-11-13 10:41 ` [PATCH 0/4] rhashtable: Allow local locks to be used and tested Thomas Graf
2014-11-13 20:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141117061654.GA8723@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=josh@joshtriplett.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).