Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: devzero@web.de
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH RESEND] fix #51791 - bug? mac 00:00:00:00:00:00 with natsemi DP83815 after driver load
Date: Wed, 19 Nov 2014 15:35:28 -0500 (EST)	[thread overview]
Message-ID: <20141119.153528.1764287151701305293.davem@davemloft.net> (raw)
In-Reply-To: <trinity-a7b6eb2e-598a-4ad0-9df5-7567cb544671-1416347483688@3capp-webde-bs54>

From: "Roland Kletzing" <devzero@web.de>
Date: Tue, 18 Nov 2014 22:51:23 +0100

> This one should fix Bugzilla #51791 

I'm sorry for being a pain, but I want to teach you how to properly
submit clean patches so that I don't need to go back and forth with
you in the future about these issues.

Your subject line needs adjusting.

After the [PATCH ...], there should be a properly subsystem prefix
followed by a colon character, which in this case could be "natsemi: "

Then, your subject line should be succinct and contain all of the
context necessary to understand exactly what the bug is about.

This means that the bug ID number doesn't belong there.  It's
completely ambiguous as to what bug repository that ID is for,
and such information belongs in the commit message body.

So when you mention bug IDs in the commit message body, say where
it's from.  If it's the main kernel bugzilla, say so.

Thanks.

      reply	other threads:[~2014-11-19 20:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-18 21:51 [PATCH RESEND] fix #51791 - bug? mac 00:00:00:00:00:00 with natsemi DP83815 after driver load Roland Kletzing
2014-11-19 20:35 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141119.153528.1764287151701305293.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=devzero@web.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox