From: Jiri Bohac <jbohac@suse.cz>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Jiri Bohac <jbohac@suse.cz>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
netdev@vger.kernel.org, David Miller <davem@davemloft.net>
Subject: Re: ipx: fix locking regression in ipx_sendmsg and ipx_recvmsg
Date: Wed, 19 Nov 2014 11:34:13 +0100 [thread overview]
Message-ID: <20141119103413.GA19092@midget.suse.cz> (raw)
In-Reply-To: <1609909.1jJeqOzgZ8@wuerfel>
On Wed, Nov 19, 2014 at 09:32:54AM +0100, Arnd Bergmann wrote:
> I'm more interested in the code structure, in particular this bit
>
> @@ -1807,8 +1812,10 @@ static int ipx_recvmsg(struct kiocb *iocb, struct socket *sock,
>
> rc = skb_copy_datagram_iovec(skb, sizeof(struct ipxhdr), msg->msg_iov,
> copied);
> - if (rc)
> - goto out_free;
> + if (rc) {
> + skb_free_datagram(sk, skb);
> + goto out;
> + }
>
>
> after your change mixes coding styles: in some failure cases you just goto
> a cleanup part, in other cases you do the cleanup before the goto.
>
> If I'm reading the patch correctly, this change has introduced a leak
Very lame of me - thanks so much for spotitng this!
Sending a restructured v3.
--
Jiri Bohac <jbohac@suse.cz>
SUSE Labs, SUSE CZ
next prev parent reply other threads:[~2014-11-19 10:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 1:34 ipx: fix locking regression in ipx_sendmsg and ipx_recvmsg Jiri Bohac
2014-11-18 13:37 ` Arnd Bergmann
2014-11-18 20:49 ` David Miller
2014-11-18 22:10 ` Jiri Bohac
2014-11-18 22:24 ` [PATCH v2] " Jiri Bohac
2014-11-19 8:32 ` Arnd Bergmann
2014-11-19 10:34 ` Jiri Bohac [this message]
2014-11-19 10:38 ` [PATCH v3] " Jiri Bohac
2014-11-19 10:50 ` Arnd Bergmann
2014-11-19 14:38 ` Sergei Shtylyov
2014-11-19 20:44 ` David Miller
2014-11-19 22:05 ` [PATCH v4] ipx: " Jiri Bohac
2014-11-19 22:12 ` Arnd Bergmann
2014-11-21 19:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141119103413.GA19092@midget.suse.cz \
--to=jbohac@suse.cz \
--cc=acme@ghostprotocols.net \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).