From: David Miller <davem@davemloft.net>
To: cwang@twopensource.com
Cc: jay.vosburgh@canonical.com, eric.dumazet@gmail.com,
wen.gang.wang@oracle.com, netdev@vger.kernel.org
Subject: Re: [PATCH] bonding: clear header_ops when last slave detached (v2)
Date: Fri, 21 Nov 2014 13:55:00 -0500 (EST) [thread overview]
Message-ID: <20141121.135500.1677711058185319746.davem@davemloft.net> (raw)
In-Reply-To: <CAHA+R7Pnn4TxRQcR4KBRrZV8mqsm-YznMMvXVasji07caY9b1g@mail.gmail.com>
From: Cong Wang <cwang@twopensource.com>
Date: Fri, 21 Nov 2014 10:17:12 -0800
> On Thu, Nov 20, 2014 at 2:53 PM, Jay Vosburgh
> <jay.vosburgh@canonical.com> wrote:
>> Cong Wang <cwang@twopensource.com> wrote:
>>
>>>Also, no one seems to care about my previous question:
>>>why only bonding has the problem?
>>
>> Bonding has the problem because it stashes a pointer to a data
>> structure (the header_ops) from another module, and when that module is
>> unloaded the dangling pointer may be dereferenced if it's not either
>> cleared or made to never go away.
>
> I knew, please re-read my question, I was asking why ONLY bonding
> has the problem, i.e. why not neigh or whatever else calling
> header_ops->foo()? :)
They are either static only (ipv4) or cannot be unloaded as a module
after being loaded (ipv6).
prev parent reply other threads:[~2014-11-21 18:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 5:18 [PATCH] bonding: clear header_ops when last slave detached (v2) Wengang Wang
2014-11-19 5:22 ` Wengang
2014-11-19 5:39 ` Eric Dumazet
2014-11-19 7:00 ` Wengang
2014-11-19 22:26 ` Cong Wang
2014-11-19 22:56 ` Cong Wang
2014-11-20 6:41 ` Eric Dumazet
2014-11-20 17:34 ` Cong Wang
2014-11-20 20:41 ` Eric Dumazet
2014-11-20 21:57 ` Cong Wang
2014-11-20 22:03 ` Eric Dumazet
2014-11-20 22:13 ` Cong Wang
2014-11-20 22:53 ` Jay Vosburgh
2014-11-21 18:17 ` Cong Wang
2014-11-21 18:54 ` Jay Vosburgh
2014-11-24 3:05 ` Wengang
2014-11-21 18:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141121.135500.1677711058185319746.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cwang@twopensource.com \
--cc=eric.dumazet@gmail.com \
--cc=jay.vosburgh@canonical.com \
--cc=netdev@vger.kernel.org \
--cc=wen.gang.wang@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).