Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: amirv@mellanox.com
Cc: ogerlitz@mellanox.com, yevgenyp@mellanox.com,
	netdev@vger.kernel.org, saeedm@mellanox.com
Subject: Re: [PATCH net-next] net/mlx4_en: mlx4_en_set_settings() always fails when autoneg is set
Date: Fri, 21 Nov 2014 15:08:50 -0500 (EST)	[thread overview]
Message-ID: <20141121.150850.1419027477033247999.davem@davemloft.net> (raw)
In-Reply-To: <1416485984-5029-1-git-send-email-amirv@mellanox.com>

From: Amir Vadai <amirv@mellanox.com>
Date: Thu, 20 Nov 2014 14:19:44 +0200

> From: Saeed Mahameed <saeedm@mellanox.com>
> 
> Fix ethtool set settings to not check AUTONEG_ENABLE
> 
> mlx4_en_set_settings should not check if cmd->autoneg == AUTONEG_ENABLE,
> cmd->autoneg can be enabled by default and this check will fail other settings requests.
> mlx4_en driver doesn't support changing autoneg value, but shouldn't fail the request
> in case cmd->autoneg was set.
> 
> Fixes: d48b3ab ("net/mlx4_en: Use PTYS register to set ethtool settings (Speed)")
> Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
> Signed-off-by: Amir Vadai <amirv@mellanox.com>

Applied, thanks.

      reply	other threads:[~2014-11-21 20:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-20 12:19 [PATCH net-next] net/mlx4_en: mlx4_en_set_settings() always fails when autoneg is set Amir Vadai
2014-11-21 20:08 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141121.150850.1419027477033247999.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=amirv@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=saeedm@mellanox.com \
    --cc=yevgenyp@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox