From: David Miller <davem@davemloft.net>
To: mleitner@redhat.com
Cc: netdev@vger.kernel.org, stephen@networkplumber.org, pshelar@nicira.com
Subject: Re: [PATCH] vxlan: move listen socket creation from workqueue to vxlan_open
Date: Fri, 21 Nov 2014 17:11:31 -0500 (EST) [thread overview]
Message-ID: <20141121.171131.1339829257521697510.davem@davemloft.net> (raw)
In-Reply-To: <a66c29751c354fe08acd459479f2eacf66e9b284.1416486751.git.mleitner@redhat.com>
From: Marcelo Ricardo Leitner <mleitner@redhat.com>
Date: Thu, 20 Nov 2014 10:33:32 -0200
> But this doesn't apply to vxlan_open() scenario. We can unlock/lock
> in there safely and, with that, we can return a better error value
> to the user if that's the case.
This is not safe.
Now nothing prevents another parallel open of this vxlan device to
occur while you dropped the RTNL semaphore.
prev parent reply other threads:[~2014-11-21 22:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 12:33 [PATCH] vxlan: move listen socket creation from workqueue to vxlan_open Marcelo Ricardo Leitner
2014-11-21 22:11 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141121.171131.1339829257521697510.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox