From: Richard Cochran <richardcochran@gmail.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
bruce.w.allan@intel.com, Jacob Keller <jacob.e.keller@intel.com>,
John Ronciak <john.ronciak@intel.com>,
Matthew Vick <matthew.vick@intel.com>, Jian Yu <jian.yu@ni.com>
Subject: Re: [PATCH net-next V2 4/4] igb: enable auxiliary PHC functions for the i210.
Date: Fri, 21 Nov 2014 13:59:10 +0100 [thread overview]
Message-ID: <20141121125910.GB6031@localhost.localdomain> (raw)
In-Reply-To: <1416573969.2280.39.camel@jtkirshe-mobl>
On Fri, Nov 21, 2014 at 04:46:09AM -0800, Jeff Kirsher wrote:
> On Fri, 2014-11-21 at 10:41 +0100, Richard Cochran wrote:
> > + /* Make sure this pin is not enabled as an ouput. */
>
> Minor nitpick, output is mis-spelled (I can fix that up for you)
Yes please.
> Probably should have a blank line after the local variable declaration.
> Again, I can fix this up for ya.
Okay.
Thanks,
Richard
next prev parent reply other threads:[~2014-11-21 12:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 9:41 [PATCH net-next V2 0/4] igb: auxiliary PHC functions for the i210 Richard Cochran
2014-11-21 9:41 ` [PATCH net-next V2 1/4] igb: refactor time sync interrupt handling Richard Cochran
2014-11-21 9:41 ` [PATCH net-next V2 2/4] igb: serialize access to the time sync interrupt registers Richard Cochran
2014-11-21 9:41 ` [PATCH net-next V2 3/4] igb: enable internal PPS for the i210 Richard Cochran
2014-11-21 9:41 ` [PATCH net-next V2 4/4] igb: enable auxiliary PHC functions " Richard Cochran
2014-11-21 12:46 ` Jeff Kirsher
2014-11-21 12:59 ` Richard Cochran [this message]
2014-11-21 12:37 ` [PATCH net-next V2 0/4] igb: " Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141121125910.GB6031@localhost.localdomain \
--to=richardcochran@gmail.com \
--cc=bruce.w.allan@intel.com \
--cc=davem@davemloft.net \
--cc=jacob.e.keller@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jian.yu@ni.com \
--cc=john.ronciak@intel.com \
--cc=matthew.vick@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox