From: David Miller <davem@davemloft.net>
To: amirv@mellanox.com
Cc: netdev@vger.kernel.org, ben@decadent.org.uk,
ogerlitz@mellanox.com, yevgenyp@mellanox.com,
eyalpe@mellanox.com, thomas.lendacky@amd.com,
ariel.elior@qlogic.com, prashant@broadcom.com,
mchan@broadcom.com, hariprasad@chelsio.com,
sathya.perla@emulex.com, subbu.seetharaman@emulex.com,
ajit.khaparde@emulex.com, jeffrey.t.kirsher@intel.com,
jesse.brandeburg@intel.com, bruce.w.allan@intel.com,
carolyn.wyborny@intel.com, donald.c.skidmore@intel.com,
gregory.v.rose@intel.com, matthew.vick@intel.com,
john.ronciak@intel.com, mitch.a.williams@intel.com,
linux-net-drivers@solarflare.com, sshah@solarflare.com,
sbhatewara@vmware.com, pv-drivers@vmware.com
Subject: Re: [PATCH net-next V1 1/2] ethtool: Support for configurable RSS hash function
Date: Sat, 22 Nov 2014 16:54:07 -0500 (EST) [thread overview]
Message-ID: <20141122.165407.641057904952001007.davem@davemloft.net> (raw)
In-Reply-To: <1416493610-8966-2-git-send-email-amirv@mellanox.com>
From: Amir Vadai <amirv@mellanox.com>
Date: Thu, 20 Nov 2014 16:26:49 +0200
> + /* We require at least one supported parameter to be changed and no
> + * change in any of the unsupported parameters
> + */
> + if ((!indir && !key) || hfunc != ETH_RSS_HASH_NO_CHANGE)
> + return -EOPNOTSUPP;
> +
I know it will make more work for you, but all of these driver
implementations of this hook should:
1) Accept hfunc of whatever hash function the chip is using,
not just ETH_RSS_HASH_NO_CHANGE.
2) Provide an accurate hfunc value in the ->get() call.
next prev parent reply other threads:[~2014-11-22 21:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 14:26 [PATCH net-next V1 0/2] ethtool, net/mlx4_en: RSS hash function selection Amir Vadai
2014-11-20 14:26 ` [PATCH net-next V1 1/2] ethtool: Support for configurable RSS hash function Amir Vadai
2014-11-22 21:54 ` David Miller [this message]
2014-11-23 10:13 ` Eyal perry
2014-11-26 20:29 ` Eyal perry
2014-11-20 14:26 ` [PATCH net-next V1 2/2] net/mlx4_en: " Amir Vadai
2014-11-20 14:34 ` [PATCH net-next V1 0/2] ethtool, net/mlx4_en: RSS hash function selection Amir Vadai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141122.165407.641057904952001007.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ajit.khaparde@emulex.com \
--cc=amirv@mellanox.com \
--cc=ariel.elior@qlogic.com \
--cc=ben@decadent.org.uk \
--cc=bruce.w.allan@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=donald.c.skidmore@intel.com \
--cc=eyalpe@mellanox.com \
--cc=gregory.v.rose@intel.com \
--cc=hariprasad@chelsio.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=linux-net-drivers@solarflare.com \
--cc=matthew.vick@intel.com \
--cc=mchan@broadcom.com \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=prashant@broadcom.com \
--cc=pv-drivers@vmware.com \
--cc=sathya.perla@emulex.com \
--cc=sbhatewara@vmware.com \
--cc=sshah@solarflare.com \
--cc=subbu.seetharaman@emulex.com \
--cc=thomas.lendacky@amd.com \
--cc=yevgenyp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox