From: Josh Triplett <josh@joshtriplett.org>
To: Pieter Smith <pieter@boesman.nl>
Cc: Willem de Bruijn <willemb@google.com>,
Alexander Duyck <alexander.h.duyck@intel.com>,
Thomas Graf <tgraf@suug.ch>,
"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
Miklos Szeredi <mszeredi@suse.cz>,
"Michael S. Tsirkin" <mst@redhat.com>,
Daniel Borkmann <dborkman@redhat.com>,
Jan Beulich <JBeulich@suse.com>,
open list <linux-kernel@vger.kernel.org>,
Paul Durrant <Paul.Durrant@citrix.com>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Tom Herbert <therbert@google.com>
Subject: Re: [PATCH 5/6] net/core: support compiling out splice
Date: Sat, 22 Nov 2014 15:07:32 -0800 [thread overview]
Message-ID: <20141122230731.GC24429@thin> (raw)
In-Reply-To: <CAPho-_+GV+2sVVxGsPSjvE3heEoGa4chbqrmnxLAr_p7RU=TDQ@mail.gmail.com>
[Please don't top-post.]
On Sat, Nov 22, 2014 at 11:50:51PM +0100, Pieter Smith wrote:
> splice exports a structure that is used by skbuf. Mocking out a function is
> straightforward. To my knowledge there is no elegant way of mocking out a
> splice_operations struct. I directly modified the code to prevent linking
> against the struct. Do you know of a better technique to get the same
> result?
No, I don't. The approach you took seems fine; I'm just saying that you
need to explain the need for it in the commit message.
- JosH Triplett
next prev parent reply other threads:[~2014-11-22 23:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1416690001-20817-1-git-send-email-pieter@boesman.nl>
2014-11-22 21:00 ` [PATCH 5/6] net/core: support compiling out splice Pieter Smith
2014-11-22 21:48 ` Josh Triplett
[not found] ` <CAPho-_+GV+2sVVxGsPSjvE3heEoGa4chbqrmnxLAr_p7RU=TDQ@mail.gmail.com>
2014-11-22 23:07 ` Josh Triplett [this message]
2014-11-23 14:20 [PATCH 0/6] kernel tinification: optionally compile out splice family of syscalls (splice, vmsplice, tee and sendfile) Pieter Smith
[not found] ` <1416752468-1626-1-git-send-email-pieter-qeJ+1H9vRZbz+pZb47iToQ@public.gmane.org>
2014-11-23 14:20 ` [PATCH 5/6] net/core: support compiling out splice Pieter Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141122230731.GC24429@thin \
--to=josh@joshtriplett.org \
--cc=JBeulich@suse.com \
--cc=Paul.Durrant@citrix.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mszeredi@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=pieter@boesman.nl \
--cc=tgraf@suug.ch \
--cc=therbert@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).