From: David Miller <davem@davemloft.net>
To: richardcochran@gmail.com
Cc: ben@decadent.org.uk, netdev@vger.kernel.org,
stefan.sorensen@spectralink.com
Subject: Re: [PATCH net-next] vlan: Pass ethtool get_ts_info queries to real device.
Date: Sun, 23 Nov 2014 13:48:09 -0500 (EST) [thread overview]
Message-ID: <20141123.134809.1311687203339230014.davem@davemloft.net> (raw)
In-Reply-To: <20141123160533.GA4562@netboy>
From: Richard Cochran <richardcochran@gmail.com>
Date: Sun, 23 Nov 2014 17:05:35 +0100
> On Sun, Nov 23, 2014 at 03:15:12AM +0000, Ben Hutchings wrote:
>> This assumes that the same PTP capabilities apply to VLAN-tagged frames.
>> I don't think it's at all safe to assume that RX filter modes other than
>> HWTSTAMP_FILTER_ALL will include VLAN-tagged frames. I think it is
>> necessary to define additional modes that explicitly include VLAN-tagged
>> frames.
>
> Unsafe? How?
>
> Do you mean that some HW cannot identify and time stamp PTP frames
> when VLAN tagged? That is surely disappointing for people who shell
> out money for such cards, but it is hardly unsafe.
Ben, you will have to provide a concrete example of a chip that will
do the wrong thing with Richard's change.
Hypotheticals won't cut it.
Thanks.
next prev parent reply other threads:[~2014-11-23 18:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 13:16 [PATCH net-next] vlan: Pass ethtool get_ts_info queries to real device Richard Cochran
2014-11-21 20:36 ` David Miller
2014-11-23 3:15 ` Ben Hutchings
2014-11-23 16:05 ` Richard Cochran
2014-11-23 17:19 ` Ben Hutchings
2014-11-23 18:38 ` Richard Cochran
2014-11-23 18:48 ` David Miller [this message]
2014-11-23 19:04 ` Ben Hutchings
2014-11-24 7:38 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141123.134809.1311687203339230014.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben@decadent.org.uk \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=stefan.sorensen@spectralink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).