* [PATCH net_test_tools] route_bench: Fix bug in DST_ITERATE option
@ 2014-11-24 8:13 Vijay Subramanian
2014-11-24 21:09 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Vijay Subramanian @ 2014-11-24 8:13 UTC (permalink / raw)
To: netdev; +Cc: davem, Vijay Subramanian
While setting option for dst_addr_stride, flags should be set for
FLAG_DST_ITERATE not FLAG_SRC_ITERATE.
Signed-off-by: Vijay Subramanian <subramanian.vijay@gmail.com>
---
route_bench.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/route_bench.c b/route_bench.c
index eb91dcf..22cbd2a 100644
--- a/route_bench.c
+++ b/route_bench.c
@@ -292,7 +292,7 @@ int main(int argc, char **argv, char **envp)
break;
case 'e':
sscanf(optarg, "%u", &s->dst_addr_stride);
- s->flags |= FLAG_SRC_ITERATE;
+ s->flags |= FLAG_DST_ITERATE;
break;
case 'f':
s->dst_addr_limit = inet_addr(optarg);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net_test_tools] route_bench: Fix bug in DST_ITERATE option
2014-11-24 8:13 [PATCH net_test_tools] route_bench: Fix bug in DST_ITERATE option Vijay Subramanian
@ 2014-11-24 21:09 ` David Miller
2014-11-25 1:18 ` Vijay Subramanian
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2014-11-24 21:09 UTC (permalink / raw)
To: subramanian.vijay; +Cc: netdev
From: Vijay Subramanian <subramanian.vijay@gmail.com>
Date: Mon, 24 Nov 2014 00:13:39 -0800
> While setting option for dst_addr_stride, flags should be set for
> FLAG_DST_ITERATE not FLAG_SRC_ITERATE.
>
> Signed-off-by: Vijay Subramanian <subramanian.vijay@gmail.com>
This does not apply to the 'net' tree.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net_test_tools] route_bench: Fix bug in DST_ITERATE option
2014-11-24 21:09 ` David Miller
@ 2014-11-25 1:18 ` Vijay Subramanian
2014-11-25 5:58 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Vijay Subramanian @ 2014-11-25 1:18 UTC (permalink / raw)
To: David Miller; +Cc: netdev
>> Signed-off-by: Vijay Subramanian <subramanian.vijay@gmail.com>
>
> This does not apply to the 'net' tree.
David,
The patch was targeted not against 'net' tree but against test suite
at https://git.kernel.org/pub/scm/linux/kernel/git/davem/net_test_tools.git
as indicated in subject. Would you like me to resubmit this making it
clear in commit log too?
-vijay
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net_test_tools] route_bench: Fix bug in DST_ITERATE option
2014-11-25 1:18 ` Vijay Subramanian
@ 2014-11-25 5:58 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2014-11-25 5:58 UTC (permalink / raw)
To: subramanian.vijay; +Cc: netdev
From: Vijay Subramanian <subramanian.vijay@gmail.com>
Date: Mon, 24 Nov 2014 17:18:27 -0800
> The patch was targeted not against 'net' tree but against test suite
> at https://git.kernel.org/pub/scm/linux/kernel/git/davem/net_test_tools.git
> as indicated in subject. Would you like me to resubmit this making it
> clear in commit log too?
Sorry, my bad. I'll re-look at your patch, sorry :)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-11-25 5:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-24 8:13 [PATCH net_test_tools] route_bench: Fix bug in DST_ITERATE option Vijay Subramanian
2014-11-24 21:09 ` David Miller
2014-11-25 1:18 ` Vijay Subramanian
2014-11-25 5:58 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).