From: David Miller <davem@davemloft.net>
To: dborkman@redhat.com
Cc: hannes@stressinduktion.org, netdev@vger.kernel.org,
yuri.chislov@gmail.com, xeb@mail.ru
Subject: Re: [PATCH net] ipv6: gre: fix wrong skb->protocol in WCCP
Date: Mon, 24 Nov 2014 16:11:27 -0500 (EST) [thread overview]
Message-ID: <20141124.161127.70670502752718043.davem@davemloft.net> (raw)
In-Reply-To: <1416824715-28733-1-git-send-email-dborkman@redhat.com>
From: Daniel Borkmann <dborkman@redhat.com>
Date: Mon, 24 Nov 2014 11:25:15 +0100
> From: Yuri Chislov <yuri.chislov@gmail.com>
>
> When using GRE redirection in WCCP, it sets the wrong skb->protocol,
> that is, ETH_P_IP instead of ETH_P_IPV6 for the encapuslated traffic.
>
> Fixes: c12b395a4664 ("gre: Support GRE over IPv6")
> Cc: Dmitry Kozlov <xeb@mail.ru>
> Signed-off-by: Yuri Chislov <yuri.chislov@gmail.com>
> Tested-by: Yuri Chislov <yuri.chislov@gmail.com>
> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
> ---
> Also checked back with Dmitry, it was a copy-paste error from the
> IPv4 implementation.
Good catch, applied, thanks Faniel.
prev parent reply other threads:[~2014-11-24 21:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 10:25 [PATCH net] ipv6: gre: fix wrong skb->protocol in WCCP Daniel Borkmann
2014-11-24 21:11 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141124.161127.70670502752718043.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
--cc=xeb@mail.ru \
--cc=yuri.chislov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).