From: David Miller <davem@davemloft.net>
To: willemb@google.com
Cc: netdev@vger.kernel.org, luto@amacapital.net, richardcochran@gmail.com
Subject: Re: [PATCH rfc 2/4] net-errqueue: add IP(V6)_PKTINFO support
Date: Tue, 25 Nov 2014 13:41:02 -0500 (EST) [thread overview]
Message-ID: <20141125.134102.1488230781371300774.davem@davemloft.net> (raw)
In-Reply-To: <1416938286-14147-3-git-send-email-willemb@google.com>
From: Willem de Bruijn <willemb@google.com>
Date: Tue, 25 Nov 2014 12:58:04 -0500
> + if (inet_sk(sk)->cmsg_flags & IP_CMSG_PKTINFO && skb->dev) {
> + struct in_pktinfo info = {0};
I think memset(&info... is cleaner, and:
> + struct in6_pktinfo info;
> +
> + memset(&info, 0, sizeof(info));
Would make the code consistent with the ipv6 side.
next prev parent reply other threads:[~2014-11-25 18:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 17:58 [PATCH rfc 0/4] timestamping updates Willem de Bruijn
2014-11-25 17:58 ` [PATCH rfc 1/4] net-timestamp: pull headers for SOCK_STREAM Willem de Bruijn
2014-11-25 18:42 ` David Miller
2014-11-25 19:52 ` Willem de Bruijn
2014-11-25 19:54 ` David Miller
2014-11-25 21:39 ` Andy Lutomirski
2014-11-26 21:03 ` Willem de Bruijn
2014-11-27 0:36 ` Andy Lutomirski
2014-11-27 12:30 ` Richard Cochran
2014-11-25 17:58 ` [PATCH rfc 2/4] net-errqueue: add IP(V6)_PKTINFO support Willem de Bruijn
2014-11-25 18:04 ` Willem de Bruijn
2014-11-25 18:41 ` David Miller [this message]
2014-11-25 21:16 ` Willem de Bruijn
2014-11-25 17:58 ` [PATCH rfc 3/4] net-timestamp: tcp sockets return v6 errors on v6 sockets Willem de Bruijn
2014-11-25 18:41 ` David Miller
2014-11-25 19:53 ` Willem de Bruijn
2014-11-25 17:58 ` [PATCH rfc 4/4] net-timestamp: expand txtimestamp test with payload and PKTINFO Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141125.134102.1488230781371300774.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=luto@amacapital.net \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).