From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: therbert@google.com, linux@stwm.de, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] gre: Set inner mac header in gro complete
Date: Tue, 25 Nov 2014 14:35:30 -0500 (EST) [thread overview]
Message-ID: <20141125.143530.1055990826405505003.davem@davemloft.net> (raw)
In-Reply-To: <1416938241.29427.37.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 25 Nov 2014 09:57:21 -0800
> On Tue, 2014-11-25 at 09:30 -0800, Tom Herbert wrote:
>> Set the inner mac header to point to the GRE payload when
>> doing GRO. This is needed if we proceed to send the packet
>> through GRE GSO which now uses the inner mac header instead
>> of inner network header to determine the length of encapsulation
>> headers.
>>
>> Reported-by: Wolfgang Walter <linux@stwm.de>
>> Signed-off-by: Tom Herbert <therbert@google.com>
>> ---
>
> Please Tom, add in your bug fixes something to ease backports.
>
> Fixes: 14051f0452a2 ("gre: Use inner mac length when computing tunnel length")
Also this is extremely far reaching consequences.
The bug is in Linus's tree, so net-next is not a suitable target,
'net' is.
Also, the commit in question has been backported into -stable, so
I would need to queue it up there as well.
Please respin this against 'net', and add the Fixes: tag, thanks.
prev parent reply other threads:[~2014-11-25 19:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 17:30 [PATCH net-next] gre: Set inner mac header in gro complete Tom Herbert
2014-11-25 17:57 ` Eric Dumazet
2014-11-25 19:35 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141125.143530.1055990826405505003.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux@stwm.de \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).