Re: [patch net-next v3 17/17] rocker: add ndo_bridge_setlnk/getlink support for learning policy

Scott Feldman
2014-11-25T18:55:35Z

On Tue, Nov 25, 2014 at 6:09 AM, Jamal Hadi Salim <jhs@mojatatu.com> wrote:
> On 11/25/14 05:28, Jiri Pirko wrote:
>>
>> From: Scott Feldman <sfeldma@gmail.com>
>>
>> Rocker ports will use new "swdev" hwmode for bridge port offload policy.
>> Current supported policy settings are BR_LEARNING and BR_LEARNING_SYNC.
>> User can turn on/off device port FDB learning and syncing to bridge.
>>
>> Signed-off-by: Scott Feldman <sfeldma@gmail.com>
>> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
>
>
> as previous comments - please submit rocker separately

I disagree. API changes need a reference implementation to show usage
and for testing. If you have have an alternate switch implementation
that achieves the same goal, bring it forward.

> cheers,
> jamal