Netdev List
 help / color / mirror / Atom feed
From: Alexander Duyck <alexander.h.duyck@redhat.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net
Subject: [net-next PATCH 1/5] etherdevice: Add function for handling padding frame to ETH_ZLEN
Date: Tue, 25 Nov 2014 14:44:00 -0800	[thread overview]
Message-ID: <20141125224400.1867.48907.stgit@ahduyck-vm-fedora20> (raw)
In-Reply-To: <20141125223727.1867.43890.stgit@ahduyck-vm-fedora20>

This patch adds a simple function for padding a frame up to the minimum
size for for Ethernet.  The motivation behind it is that there are a number
of implementations throughout the network device drivers that are all doing
the same thing, but each a little bit differently and as a result several
implementations contain bugs such as updating the length without updating
the tail offset and other similar issues.

Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>
---
 include/linux/etherdevice.h |   21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h
index 733980f..7e436f3 100644
--- a/include/linux/etherdevice.h
+++ b/include/linux/etherdevice.h
@@ -392,4 +392,25 @@ static inline unsigned long compare_ether_header(const void *a, const void *b)
 #endif
 }
 
+/**
+ * eth_skb_pad - Pad buffer to mininum number of octets for Ethernet frame
+ * @skb: Buffer to pad
+ *
+ * An Ethernet frame should have a minimum size of 60 bytes.  This function
+ * takes short frames and pads them with zeros up to the 60 byte limit.
+ */
+static inline int eth_skb_pad(struct sk_buff *skb)
+{
+	unsigned int size = skb->len;
+
+	if (unlikely(size < ETH_ZLEN)) {
+		size = ETH_ZLEN - size;
+		if (skb_pad(skb, size))
+			return -ENOMEM;
+		__skb_put(skb, size);
+	}
+
+	return 0;
+}
+
 #endif	/* _LINUX_ETHERDEVICE_H */

  reply	other threads:[~2014-11-25 22:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-25 22:43 [net-next PATCH 0/5] net: Add helper for padding short Ethernet frames Alexander Duyck
2014-11-25 22:44 ` Alexander Duyck [this message]
2014-11-26  0:56   ` [net-next PATCH 1/5] etherdevice: Add function for handling padding frame to ETH_ZLEN Florian Fainelli
2014-11-26  2:44     ` Alexander Duyck
2014-11-25 22:44 ` [net-next PATCH 2/5] ethernet/intel: Use eth_skb_pad helper Alexander Duyck
2014-11-25 23:14   ` Eric Dumazet
2014-11-26  0:44     ` Alexander Duyck
2014-11-26  1:05       ` Florian Fainelli
2014-11-26  1:43       ` Eric Dumazet
2014-11-26  3:19         ` David Miller
2014-11-26  4:01           ` Eric Dumazet
2014-11-26 20:41             ` David Miller
2014-11-25 22:44 ` [net-next PATCH 3/5] niu: " Alexander Duyck
2014-11-25 22:44 ` [net-next PATCH 4/5] myri10ge: use " Alexander Duyck
2014-11-25 22:44 ` [net-next PATCH 5/5] r8169: Use eth_skb_pad function Alexander Duyck
2014-11-26  0:02   ` Francois Romieu
2014-11-26  0:33     ` Alexander Duyck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141125224400.1867.48907.stgit@ahduyck-vm-fedora20 \
    --to=alexander.h.duyck@redhat.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox