From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] r8152: drop the tx packet with invalid length Date: Wed, 26 Nov 2014 12:06:58 -0500 (EST) Message-ID: <20141126.120658.498602780456343676.davem@davemloft.net> References: <1394712342-15778-104-Taiwan-albertk@realtek.com> <1417020748.29427.59.camel@edumazet-glaptop2.roam.corp.google.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: hayeswang@realtek.com, netdev@vger.kernel.org, nic_swsd@realtek.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org To: eric.dumazet@gmail.com Return-path: In-Reply-To: <1417020748.29427.59.camel@edumazet-glaptop2.roam.corp.google.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Eric Dumazet Date: Wed, 26 Nov 2014 08:52:28 -0800 > On Wed, 2014-11-26 at 17:56 +0800, Hayes Wang wrote: >> Drop the tx packet which is more than the size of agg_buf_sz. When >> creating a bridge with the device, we may get the tx packet with >> TSO and the length is more than the gso_max_size which is set by >> the driver through netif_set_gso_max_size(). Such packets couldn't >> be transmitted and should be dropped directly. >> >> Signed-off-by: Hayes Wang ... > Looks like a candidate for ndo_gso_check(), so that we do not drop, but > instead segment from netif_needs_gso()/validate_xmit_skb() You mean have the bridge implement the ndo_gso_check() method right?