From: Stephen Hemminger <stephen@networkplumber.org>
To: Mirko Lindner <mlindner@marvell.com>
Cc: <davem@davemloft.net>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] sky2: Fix crash inside sky2_rx_clean
Date: Wed, 26 Nov 2014 10:57:10 -0800 [thread overview]
Message-ID: <20141126105710.0622a7c0@urahara> (raw)
In-Reply-To: <5475E012.3060607@marvell.com>
On Wed, 26 Nov 2014 15:13:38 +0100
Mirko Lindner <mlindner@marvell.com> wrote:
> If sky2->tx_le = pci_alloc_consistent() or sky2->tx_ring = kcalloc() in
> sky2_alloc_buffers() fails, sky2->rx_ring = kcalloc() will never be called.
> In this error case handling, sky2_rx_clean() is called from within
> sky2_free_buffers().
>
> In sky2_rx_clean() we find the following:
>
> ...
> memset(sky2->rx_le, 0, RX_LE_BYTES);
> ...
>
> This results in a memset using a NULL pointer and will crash the system.
>
> Signed-off-by: Mirko Lindner <mlindner@marvell.com>
This matches my earlier patch, but this one is just as good
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2014-11-26 18:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 14:13 [PATCH net-next] sky2: Fix crash inside sky2_rx_clean Mirko Lindner
2014-11-26 18:57 ` Stephen Hemminger [this message]
2014-11-26 20:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141126105710.0622a7c0@urahara \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=mlindner@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).