From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCH v4 20/42] virtio_net: pass vi around Date: Wed, 26 Nov 2014 13:35:24 +0100 Message-ID: <20141126133524.27e9beb6.cornelia.huck@de.ibm.com> References: <1416933600-21398-1-git-send-email-mst@redhat.com> <1416933600-21398-21-git-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: rusty@au1.ibm.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, pbonzini@redhat.com, David Miller To: "Michael S. Tsirkin" Return-path: In-Reply-To: <1416933600-21398-21-git-send-email-mst@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On Tue, 25 Nov 2014 18:42:49 +0200 "Michael S. Tsirkin" wrote: > Too many places poke at [rs]q->vq->vdev->priv just to get > the the vi structure. Let's just pass the pointer around: seems s/the the/the/ > cleaner, and might even be faster. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/net/virtio_net.c | 38 ++++++++++++++++++++------------------ > 1 file changed, 20 insertions(+), 18 deletions(-) > Looks reasonable. Reviewed-by: Cornelia Huck