Re: [PATCH 0/5 net] bridge: Fix missing Netlink message validations

[Thomas Graf <tgraf@suug.ch>]

On 11/26/14 at 08:58am, John Fastabend wrote:
> On 11/26/2014 04:42 AM, Thomas Graf wrote:
> >Adds various missing length checks in the bridging code for Netlink
> >messages and corresponding attributes provided by user space.
> >
> >Thomas Graf (5):
> >   bridge: Validate IFLA_BRIDGE_FLAGS attribute length
> >   net: Validate IFLA_BRIDGE_MODE attribute length
> >   net: Check for presence of IFLA_AF_SPEC
> >   bridge: Add missing policy entry for IFLA_BRPORT_FAST_LEAVE
> >   bridge: Sanitize IFLA_EXT_MASK for AF_BRIDGE:RTM_GETLINK
> >
> >  drivers/net/ethernet/emulex/benet/be_main.c   |  5 +++++
> >  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |  5 +++++
> >  net/bridge/br_netlink.c                       |  1 +
> >  net/core/rtnetlink.c                          | 23 ++++++++++++++++++-----
> >  4 files changed, 29 insertions(+), 5 deletions(-)
> >
> 
> +Jiri
> 
> Looks like a miss in bond_netlink also? Seems like writing
> a smatch or cocci check for this would be worthwhile.

Thanks, I'll take a look.

The cocci check is somewhat difficult as validation is often
centralized and decoupled from actual access to implement atomic
operations. I'll give it a try though.