From: Richard Cochran <richardcochran@gmail.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Willem de Bruijn <willemb@google.com>,
David Miller <davem@davemloft.net>,
Network Development <netdev@vger.kernel.org>
Subject: Re: [PATCH rfc 1/4] net-timestamp: pull headers for SOCK_STREAM
Date: Thu, 27 Nov 2014 13:30:40 +0100 [thread overview]
Message-ID: <20141127123040.GA4443@localhost.localdomain> (raw)
In-Reply-To: <CALCETrW+2Q-R8ekVW=u=3Xb5YvYK=4RnuuWCvAG8pyc9eG6DQg@mail.gmail.com>
On Wed, Nov 26, 2014 at 04:36:39PM -0800, Andy Lutomirski wrote:
> Is there any reason to believe that unconditionally dropping the
> headers would break anything? I find it a bit hard to believe that
> anyone has actually implemented logic to figure out *what* L2 header
> type should be decoded and decode it.
Documentation/networking/timestamping/timestamping.c
else if (!memcmp(sync, data + res - sizeof(sync),
sizeof(sync)))
printf(" => GOT OUR DATA BACK (HURRAY!)");
The example program looks from the end of the buffer, ignoring the lower headers.
Thanks,
Richard
next prev parent reply other threads:[~2014-11-27 12:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 17:58 [PATCH rfc 0/4] timestamping updates Willem de Bruijn
2014-11-25 17:58 ` [PATCH rfc 1/4] net-timestamp: pull headers for SOCK_STREAM Willem de Bruijn
2014-11-25 18:42 ` David Miller
2014-11-25 19:52 ` Willem de Bruijn
2014-11-25 19:54 ` David Miller
2014-11-25 21:39 ` Andy Lutomirski
2014-11-26 21:03 ` Willem de Bruijn
2014-11-27 0:36 ` Andy Lutomirski
2014-11-27 12:30 ` Richard Cochran [this message]
2014-11-25 17:58 ` [PATCH rfc 2/4] net-errqueue: add IP(V6)_PKTINFO support Willem de Bruijn
2014-11-25 18:04 ` Willem de Bruijn
2014-11-25 18:41 ` David Miller
2014-11-25 21:16 ` Willem de Bruijn
2014-11-25 17:58 ` [PATCH rfc 3/4] net-timestamp: tcp sockets return v6 errors on v6 sockets Willem de Bruijn
2014-11-25 18:41 ` David Miller
2014-11-25 19:53 ` Willem de Bruijn
2014-11-25 17:58 ` [PATCH rfc 4/4] net-timestamp: expand txtimestamp test with payload and PKTINFO Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141127123040.GA4443@localhost.localdomain \
--to=richardcochran@gmail.com \
--cc=davem@davemloft.net \
--cc=luto@amacapital.net \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).