From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Cochran Subject: Re: [PATCH rfc 1/4] net-timestamp: pull headers for SOCK_STREAM Date: Thu, 27 Nov 2014 13:30:40 +0100 Message-ID: <20141127123040.GA4443@localhost.localdomain> References: <1416938286-14147-2-git-send-email-willemb@google.com> <20141125.134240.861582393401487675.davem@davemloft.net> <20141125.145434.1790615963499624322.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Willem de Bruijn , David Miller , Network Development To: Andy Lutomirski Return-path: Received: from mail-wi0-f174.google.com ([209.85.212.174]:61948 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754803AbaK0Map (ORCPT ); Thu, 27 Nov 2014 07:30:45 -0500 Received: by mail-wi0-f174.google.com with SMTP id h11so15594521wiw.13 for ; Thu, 27 Nov 2014 04:30:44 -0800 (PST) Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Nov 26, 2014 at 04:36:39PM -0800, Andy Lutomirski wrote: > Is there any reason to believe that unconditionally dropping the > headers would break anything? I find it a bit hard to believe that > anyone has actually implemented logic to figure out *what* L2 header > type should be decoded and decode it. Documentation/networking/timestamping/timestamping.c else if (!memcmp(sync, data + res - sizeof(sync), sizeof(sync))) printf(" => GOT OUR DATA BACK (HURRAY!)"); The example program looks from the end of the buffer, ignoring the lower headers. Thanks, Richard