From: Al Viro <viro@ZenIV.linux.org.uk>
To: Marcelo Ricardo Leitner <mleitner@redhat.com>
Cc: herbert@gondor.apana.org.au, netdev <netdev@vger.kernel.org>
Subject: Re: tun issue after e0b46d0ee9c: tun: Use iovec iterators
Date: Fri, 28 Nov 2014 22:35:03 +0000 [thread overview]
Message-ID: <20141128223503.GE29748@ZenIV.linux.org.uk> (raw)
In-Reply-To: <5478F2BB.9050409@redhat.com>
On Fri, Nov 28, 2014 at 08:10:03PM -0200, Marcelo Ricardo Leitner wrote:
> >Could you print vnet_hdr_sz and sizeof(gso) right after that
> >copy_from_iter(&gso, ...)?
>
> Did a:
> else {
> err = skb_copy_datagram_from_iter(skb, 0, from, len);
> + pr_err("vnet_hdr_sz=%d sizeof(gso)=%lu\n",
> tun->vnet_hdr_sz, sizeof(gso));
> if (!err && msg_control) {
>
> Got, for tun:
> [ 50.514165] tun: vnet_hdr_sz=12 sizeof(gso)=10
>
> for tap:
> [ 82.911840] tun: vnet_hdr_sz=10 sizeof(gso)=10
>
> other values were just as before.
Hmm... Do you have
commit 8c847d254146d32c86574a1b16923ff91bb784dd
Author: Jason Wang <jasowang@redhat.com>
Date: Thu Nov 13 16:54:14 2014 +0800
tun: fix issues of iovec iterators using in tun_put_user()
in your tree?
next prev parent reply other threads:[~2014-11-28 22:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 19:25 tun issue after e0b46d0ee9c: tun: Use iovec iterators Marcelo Ricardo Leitner
2014-11-28 20:37 ` Al Viro
2014-11-28 22:10 ` Marcelo Ricardo Leitner
2014-11-28 22:35 ` Al Viro [this message]
2014-11-29 4:49 ` Marcelo Ricardo Leitner
2014-11-28 23:59 ` Herbert Xu
2014-11-29 5:08 ` Marcelo Ricardo Leitner
2014-11-30 8:21 ` Herbert Xu
2014-12-01 13:05 ` Marcelo Ricardo Leitner
2014-11-30 10:03 ` Herbert Xu
2014-12-01 5:33 ` Jason Wang
2014-12-03 4:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141128223503.GE29748@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=herbert@gondor.apana.org.au \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).