From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next V3] tun/macvtap: use consume_skb() instead of kfree_skb() when needed Date: Sat, 29 Nov 2014 21:03:50 -0800 (PST) Message-ID: <20141129.210350.1994537005887744173.davem@davemloft.net> References: <1417070166-7026-1-git-send-email-jasowang@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, mst@redhat.com, eric.dumazet@gmail.com To: jasowang@redhat.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:54862 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751839AbaK3E7l (ORCPT ); Sat, 29 Nov 2014 23:59:41 -0500 In-Reply-To: <1417070166-7026-1-git-send-email-jasowang@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Jason Wang Date: Thu, 27 Nov 2014 14:36:06 +0800 > To be more friendly with drop monitor, we should only call kfree_skb() when > the packets were dropped and use consume_skb() in other cases. > > Cc: Eric Dumazet > Signed-off-by: Jason Wang > --- > Changes from V2: > - use unlikely() when necessary > Changes from V1: > - check the return value of tun/macvtap_put_user() This does not apply cleanly to net-next and will thus need to be respun, thanks.