From: David Miller <davem@davemloft.net>
To: chenhc@lemote.com
Cc: peppe.cavallaro@st.com, vbridgers2013@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH V2] stmmac: platform: Move plat_dat checking earlier
Date: Sat, 29 Nov 2014 21:12:25 -0800 (PST) [thread overview]
Message-ID: <20141129.211225.2031104016189256005.davem@davemloft.net> (raw)
In-Reply-To: <1417093534-21884-1-git-send-email-chenhc@lemote.com>
From: Huacai Chen <chenhc@lemote.com>
Date: Thu, 27 Nov 2014 21:05:34 +0800
> Original code only check/alloc plat_dat for the CONFIG_OF case, this
> patch check/alloc it earlier and unconditionally to avoid kernel build
> warnings:
>
> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:275
> stmmac_pltfr_probe() warn: variable dereferenced before check 'plat_dat'
>
> V2: Fix coding style.
>
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
Applied, thanks.
prev parent reply other threads:[~2014-11-30 5:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 13:05 [PATCH V2] stmmac: platform: Move plat_dat checking earlier Huacai Chen
2014-11-30 5:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141129.211225.2031104016189256005.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chenhc@lemote.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=vbridgers2013@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).