From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudip Mukherjee Subject: Re: [PATCH] e1000: remove unused variables Date: Mon, 1 Dec 2014 10:24:46 +0530 Message-ID: <20141201045446.GA3277@sudip-PC> References: <1417065728-5592-1-git-send-email-sudipm.mukherjee@gmail.com> <1417311913.7215.111.camel@decadent.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Linux NICS , e1000-devel@lists.sourceforge.net, Bruce Allan , Jesse Brandeburg , linux-kernel@vger.kernel.org, John Ronciak , netdev@vger.kernel.org To: Ben Hutchings Return-path: Content-Disposition: inline In-Reply-To: <1417311913.7215.111.camel@decadent.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: e1000-devel-bounces@lists.sourceforge.net List-Id: netdev.vger.kernel.org On Sun, Nov 30, 2014 at 01:45:13AM +0000, Ben Hutchings wrote: > On Wed, 2014-11-26 at 21:59 -0800, Hisashi T Fujinaka wrote: > > I'm pretty sure those double reads are there for a reason, so most of > > this I'm going to have to check on Monday. We have a long holiday > > weekend here in the US. > [...] > > If there were double register reads being replaced with single register > reads, I'd agree this was likely to introduce a regression. But all I > see is var = er32(REG) being changed to er32(REG). no, double register reads are not modified. only the unused variables are removed. thanks sudip > > Ben. > > -- > Ben Hutchings > The world is coming to an end. Please log off. ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired