From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCH v7 36/46] vhost/net: suppress compiler warning Date: Mon, 1 Dec 2014 13:37:40 +0100 Message-ID: <20141201133740.56d7d6d8.cornelia.huck@de.ibm.com> References: <1417359787-10138-1-git-send-email-mst@redhat.com> <1417359787-10138-37-git-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: thuth@linux.vnet.ibm.com, kvm@vger.kernel.org, rusty@au1.ibm.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, dahi@linux.vnet.ibm.com, pbonzini@redhat.com, David Miller To: "Michael S. Tsirkin" Return-path: In-Reply-To: <1417359787-10138-37-git-send-email-mst@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On Sun, 30 Nov 2014 17:12:13 +0200 "Michael S. Tsirkin" wrote: > len is always initialized since function is called with size > 0. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/vhost/net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c > index 984242e..54ffbb0 100644 > --- a/drivers/vhost/net.c > +++ b/drivers/vhost/net.c > @@ -501,7 +501,7 @@ static int get_rx_bufs(struct vhost_virtqueue *vq, > int headcount = 0; > unsigned d; > int r, nlogs = 0; > - u32 len; > + u32 uninitialized_var(len); > > while (datalen > 0 && headcount < quota) { > if (unlikely(seg >= UIO_MAXIOV)) { Want to merge this with the patch introducing the variable and add a comment there?