From: Willy Tarreau <w@1wt.eu>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org,
Maggie Mae Roxas <maggie.mae.roxas@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Subject: Re: [PATCH] net: mvneta: fix race condition in mvneta_tx()
Date: Tue, 2 Dec 2014 13:40:43 +0100 [thread overview]
Message-ID: <20141202124043.GB16347@1wt.eu> (raw)
In-Reply-To: <1417523835.5303.41.camel@edumazet-glaptop2.roam.corp.google.com>
On Tue, Dec 02, 2014 at 04:37:15AM -0800, Eric Dumazet wrote:
> On Tue, 2014-12-02 at 04:30 -0800, Eric Dumazet wrote:
> > From: Eric Dumazet <edumazet@google.com>
> >
> > mvneta_tx() dereferences skb to get skb->len too late,
> > as hardware might have completed the transmit and TX completion
> > could have freed the skb from another cpu.
> >
> > Signed-off-by: Eric Dumazet <edumazet@google.com>
>
>
>
> For completeness, this bug was added in linux-3.14 and seems a stable
> candidate.
>
> Fixes: 71f6d1b31fb1 ("net: mvneta: replace Tx timer with a real interrupt")
Absolutely, we backported this one back to 3.10.
Thanks Eric!
Willy
next prev parent reply other threads:[~2014-12-02 12:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 7:13 [PATCH] net: mvneta: fix Tx interrupt delay Willy Tarreau
2014-12-02 12:18 ` Eric Dumazet
2014-12-02 12:30 ` [PATCH] net: mvneta: fix race condition in mvneta_tx() Eric Dumazet
2014-12-02 12:37 ` Eric Dumazet
2014-12-02 12:40 ` Willy Tarreau [this message]
2014-12-09 1:55 ` David Miller
2014-12-02 12:39 ` [PATCH] net: mvneta: fix Tx interrupt delay Willy Tarreau
2014-12-02 13:04 ` Eric Dumazet
2014-12-02 13:24 ` Willy Tarreau
2014-12-02 15:17 ` Eric Dumazet
2014-12-02 17:12 ` Ezequiel Garcia
2014-12-02 17:31 ` Dave Taht
2014-12-02 18:39 ` Eric Dumazet
2014-12-09 1:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141202124043.GB16347@1wt.eu \
--to=w@1wt.eu \
--cc=eric.dumazet@gmail.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=maggie.mae.roxas@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).