From: Willy Tarreau <w@1wt.eu>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org,
Maggie Mae Roxas <maggie.mae.roxas@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Subject: Re: [PATCH] net: mvneta: fix Tx interrupt delay
Date: Tue, 2 Dec 2014 14:24:12 +0100 [thread overview]
Message-ID: <20141202132412.GC16347@1wt.eu> (raw)
In-Reply-To: <1417525458.5303.48.camel@edumazet-glaptop2.roam.corp.google.com>
On Tue, Dec 02, 2014 at 05:04:18AM -0800, Eric Dumazet wrote:
> On Tue, 2014-12-02 at 13:39 +0100, Willy Tarreau wrote:
> > Hi Eric,
> >
> > On Tue, Dec 02, 2014 at 04:18:08AM -0800, Eric Dumazet wrote:
> >
> > > I highly suggest BQL for this driver, now this issue is fixed.
> >
> > How does that work ?
>
> This works very well ;)
>
> Its super easy to implement, take a look at commits
> bdbc063129e811264cd6c311d8c2d9b95de01231 or
> 7070ce0a6419a118842298bc967061ad6cea40db
Thanks but I'm not sure I entirely understand the concept. Is it to
notify the sender that the packets were already queued for the NIC ?
And if so, how does that improve the situation ? I'm sorry if this
sounds like a stupid question, it's just that the concept by itself
is not clear to me.
Willy
next prev parent reply other threads:[~2014-12-02 13:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 7:13 [PATCH] net: mvneta: fix Tx interrupt delay Willy Tarreau
2014-12-02 12:18 ` Eric Dumazet
2014-12-02 12:30 ` [PATCH] net: mvneta: fix race condition in mvneta_tx() Eric Dumazet
2014-12-02 12:37 ` Eric Dumazet
2014-12-02 12:40 ` Willy Tarreau
2014-12-09 1:55 ` David Miller
2014-12-02 12:39 ` [PATCH] net: mvneta: fix Tx interrupt delay Willy Tarreau
2014-12-02 13:04 ` Eric Dumazet
2014-12-02 13:24 ` Willy Tarreau [this message]
2014-12-02 15:17 ` Eric Dumazet
2014-12-02 17:12 ` Ezequiel Garcia
2014-12-02 17:31 ` Dave Taht
2014-12-02 18:39 ` Eric Dumazet
2014-12-09 1:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141202132412.GC16347@1wt.eu \
--to=w@1wt.eu \
--cc=eric.dumazet@gmail.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=maggie.mae.roxas@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).