From: Stephen Hemminger <shemming@brocade.com>
To: "Pavel Šimerda" <psimerda@redhat.com>
Cc: <netdev@vger.kernel.org>
Subject: Re: [PATCH iproute2] ip route: don't assume default route
Date: Wed, 3 Dec 2014 09:17:02 -0800 [thread overview]
Message-ID: <20141203091702.75431f80@urahara> (raw)
In-Reply-To: <20141202164510.GA9005@mole.pavlix.net>
On Tue, 2 Dec 2014 17:45:10 +0100
=?UTF-8?q?Pavel=20=C5=A0imerda?= <psimerda@redhat.com> wrote:
> Just print the help when "ip route del" is called without any other
> arguments.
>
> Resolves:
>
> * https://bugzilla.redhat.com/show_bug.cgi?id=997965
>
> Signed-off-by: Pavel Šimerda <psimerda@redhat.com>
> ---
> ip/iproute.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/ip/iproute.c b/ip/iproute.c
> index d77b1e3..c171f29 100644
> --- a/ip/iproute.c
> +++ b/ip/iproute.c
> @@ -975,6 +975,9 @@ static int iproute_modify(int cmd, unsigned flags, int argc, char **argv)
> argc--; argv++;
> }
>
> + if (!dst_ok)
> + usage();
> +
> if (d || nhs_ok) {
> int idx;
>
Good catch. Applied
prev parent reply other threads:[~2014-12-03 17:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 16:45 [PATCH iproute2] ip route: don't assume default route =?UTF-8?q?Pavel=20=C5=A0imerda?=
2014-12-03 17:17 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141203091702.75431f80@urahara \
--to=shemming@brocade.com \
--cc=netdev@vger.kernel.org \
--cc=psimerda@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).