From: Alexander Duyck <alexander.h.duyck@redhat.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net
Subject: [PATCH v2 0/6] net: Add helper for padding short Ethernet frames
Date: Wed, 03 Dec 2014 08:17:26 -0800 [thread overview]
Message-ID: <20141203161440.9223.39633.stgit@ahduyck-vm-fedora20> (raw)
This patch series adds a pair of helpers to pad short Ethernet frames. The
general idea is to clean up a number of code paths that were all writing
their own versions of the same or similar function.
An added advantage is that this will help to discourage introducing new
bugs as in at least one case I found the skb->len had been updated, but the
tail pointer update was overlooked.
v2: Added skb_put_padto for cases where length is not ETH_ZLEN
Updated intel drivers and emulex driver to use skb_put_padto
Updated eth_skb_pad to use skb_put_padto
---
Alexander Duyck (6):
net: Add functions for handling padding frame and adding to length
ethernet/intel: Use eth_skb_pad and skb_put_padto helpers
emulex: Use skb_put_padto instead of skb_padto() and skb->len assignment
niu: Use eth_skb_pad helper
myri10ge: use eth_skb_pad helper
r8169: Use eth_skb_pad function
drivers/net/ethernet/emulex/benet/be_main.c | 3 +--
drivers/net/ethernet/intel/e1000/e1000_main.c | 8 ++-----
drivers/net/ethernet/intel/e1000e/netdev.c | 8 ++-----
drivers/net/ethernet/intel/fm10k/fm10k_main.c | 11 +++-------
drivers/net/ethernet/intel/i40e/i40e_txrx.c | 8 ++-----
drivers/net/ethernet/intel/igb/igb_main.c | 19 ++++-------------
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 19 ++++-------------
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 11 +++-------
drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 15 ++++---------
drivers/net/ethernet/realtek/r8169.c | 12 ++---------
drivers/net/ethernet/sun/niu.c | 9 ++------
include/linux/etherdevice.h | 12 +++++++++++
include/linux/skbuff.h | 24 ++++++++++++++++++++-
13 files changed, 67 insertions(+), 92 deletions(-)
--
next reply other threads:[~2014-12-03 16:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 16:17 Alexander Duyck [this message]
2014-12-03 16:17 ` [PATCH v2 1/6] net: Add functions for handling padding frame and adding to length Alexander Duyck
2014-12-03 16:17 ` [PATCH v2 2/6] ethernet/intel: Use eth_skb_pad and skb_put_padto helpers Alexander Duyck
2014-12-03 19:25 ` Jeff Kirsher
2014-12-03 16:17 ` [PATCH v2 3/6] emulex: Use skb_put_padto instead of skb_padto() and skb->len assignment Alexander Duyck
2014-12-03 16:17 ` [PATCH v2 4/6] niu: Use eth_skb_pad helper Alexander Duyck
2014-12-03 16:17 ` [PATCH v2 5/6] myri10ge: use " Alexander Duyck
2014-12-03 18:56 ` Sergei Shtylyov
2014-12-03 16:18 ` [PATCH v2 6/6] r8169: Use eth_skb_pad function Alexander Duyck
2014-12-09 1:48 ` [PATCH v2 0/6] net: Add helper for padding short Ethernet frames David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141203161440.9223.39633.stgit@ahduyck-vm-fedora20 \
--to=alexander.h.duyck@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox