netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Timo Teras <timo.teras@iki.fi>
To: Tom Herbert <therbert@google.com>,
	Alexander Duyck <alexander.h.duyck@redhat.com>,
	netdev@vger.kernel.org
Subject: Possible regression: "gre: Use inner mac length when computing tunnel length"
Date: Thu, 4 Dec 2014 14:16:16 +0200	[thread overview]
Message-ID: <20141204141616.185b88c4@vostro> (raw)

Hi,

After upgrading to latest 3.14.24 or newer, I noticed a weird TSO bug
in the "dmvpn" setup I use. And seems 3.14.23 works just fine. So the
commit 14051f0452a2c26a "gre: Use inner mac length when computing
tunnel length" would appear to be the related commit (but have not yet
tested this).

In practice what happens is that forwarding path between ethX (or vlanX)
and gre1 gets broken.

There's probably two differences to the "regular" gre tunnel case:
- it's nbma mode, meaning the gre header is inserted via slightly
  different code path
- the gre1 packets are IPsec encrypted in transport mode

As additional detail, doing "ethtool -K gre1 tso off" will workaround
the issue, so it is clearly tso issue pointing even further to the
commit in question.

Is this something the suspected patch could cause? Any suggestions
what to test more?

Thanks,
Timo
 

             reply	other threads:[~2014-12-04 12:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-04 12:16 Timo Teras [this message]
2014-12-04 16:00 ` Possible regression: "gre: Use inner mac length when computing tunnel length" Tom Herbert
2014-12-09  6:26   ` Timo Teras
2014-12-09  6:44     ` Timo Teras
2014-12-09 21:23       ` Tom Herbert
2014-12-11  7:14         ` [net] gre: fix the inner mac header in nbma gre tunnels xmit path Timo Teräs
2014-12-11 19:36           ` David Miller
2014-12-11 19:44             ` Timo Teras
2014-12-11 20:07               ` David Miller
2014-12-15  7:24                 ` [PATCH net, v2] gre: fix the inner mac header in nbma tunnel " Timo Teräs
2014-12-15 16:46                   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141204141616.185b88c4@vostro \
    --to=timo.teras@iki.fi \
    --cc=alexander.h.duyck@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=therbert@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).