From: David Miller <davem@davemloft.net>
To: andriy.shevchenko@linux.intel.com
Cc: chenhc@lemote.com, peppe.cavallaro@st.com, netdev@vger.kernel.org
Subject: Re: is the commit 571dcfde2371 (net-next) a proper fix?
Date: Mon, 08 Dec 2014 19:35:32 -0500 (EST) [thread overview]
Message-ID: <20141208.193532.411317230886917624.davem@davemloft.net> (raw)
In-Reply-To: <1418034200.17201.45.camel@linux.intel.com>
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Mon, 08 Dec 2014 12:23:20 +0200
> It seems for me that commit 571dcfde2371 (stmmac: platform: fix default
> values of the filter bins setting) is redundant (moreover, it could be a
> cause of crash in some cases when there is no platform data defined in
> case of CONFIG_OF).
>
> In case of no OF the platform data should be provided by platform code
> where the defaults are set. What did I miss?
You missed follow-up fix:
commit 28603d13997e2ef47f18589cc9a44553aad49c86
Author: Huacai Chen <chenhc@lemote.com>
Date: Thu Nov 27 21:05:34 2014 +0800
stmmac: platform: Move plat_dat checking earlier
next prev parent reply other threads:[~2014-12-09 0:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 10:23 is the commit 571dcfde2371 (net-next) a proper fix? Andy Shevchenko
2014-12-09 0:35 ` David Miller [this message]
2014-12-09 9:25 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141208.193532.411317230886917624.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=chenhc@lemote.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).