* is the commit 571dcfde2371 (net-next) a proper fix?
@ 2014-12-08 10:23 Andy Shevchenko
2014-12-09 0:35 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2014-12-08 10:23 UTC (permalink / raw)
To: Huacai Chen; +Cc: Giuseppe Cavallaro, David S. Miller, netdev
Hi!
It seems for me that commit 571dcfde2371 (stmmac: platform: fix default
values of the filter bins setting) is redundant (moreover, it could be a
cause of crash in some cases when there is no platform data defined in
case of CONFIG_OF).
In case of no OF the platform data should be provided by platform code
where the defaults are set. What did I miss?
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: is the commit 571dcfde2371 (net-next) a proper fix?
2014-12-08 10:23 is the commit 571dcfde2371 (net-next) a proper fix? Andy Shevchenko
@ 2014-12-09 0:35 ` David Miller
2014-12-09 9:25 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2014-12-09 0:35 UTC (permalink / raw)
To: andriy.shevchenko; +Cc: chenhc, peppe.cavallaro, netdev
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Mon, 08 Dec 2014 12:23:20 +0200
> It seems for me that commit 571dcfde2371 (stmmac: platform: fix default
> values of the filter bins setting) is redundant (moreover, it could be a
> cause of crash in some cases when there is no platform data defined in
> case of CONFIG_OF).
>
> In case of no OF the platform data should be provided by platform code
> where the defaults are set. What did I miss?
You missed follow-up fix:
commit 28603d13997e2ef47f18589cc9a44553aad49c86
Author: Huacai Chen <chenhc@lemote.com>
Date: Thu Nov 27 21:05:34 2014 +0800
stmmac: platform: Move plat_dat checking earlier
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: is the commit 571dcfde2371 (net-next) a proper fix?
2014-12-09 0:35 ` David Miller
@ 2014-12-09 9:25 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2014-12-09 9:25 UTC (permalink / raw)
To: David Miller; +Cc: chenhc, peppe.cavallaro, netdev
On Mon, 2014-12-08 at 19:35 -0500, David Miller wrote:
> > It seems for me that commit 571dcfde2371 (stmmac: platform: fix default
> > values of the filter bins setting) is redundant (moreover, it could be a
> > cause of crash in some cases when there is no platform data defined in
> > case of CONFIG_OF).
> >
> > In case of no OF the platform data should be provided by platform code
> > where the defaults are set. What did I miss?
>
> You missed follow-up fix:
>
> commit 28603d13997e2ef47f18589cc9a44553aad49c86
> Author: Huacai Chen <chenhc@lemote.com>
> Date: Thu Nov 27 21:05:34 2014 +0800
>
> stmmac: platform: Move plat_dat checking earlier
Thanks, now it makes sense, indeed.
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-09 9:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-08 10:23 is the commit 571dcfde2371 (net-next) a proper fix? Andy Shevchenko
2014-12-09 0:35 ` David Miller
2014-12-09 9:25 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).