From: Eli Cohen <eli@dev.mellanox.co.il>
To: Don Dutile <ddutile@redhat.com>
Cc: Yuval Mintz <Yuval.Mintz@qlogic.com>,
Eli Cohen <eli@dev.mellanox.co.il>,
"bhelgaas@google.com" <bhelgaas@google.com>,
David Miller <davem@davemloft.net>,
linux-pci <linux-pci@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
"ogerlitz@mellanox.com" <ogerlitz@mellanox.com>,
"yevgenyp@mellanox.com" <yevgenyp@mellanox.com>
Subject: Re: [PATCH RFC] pci: Control whether VFs are probed on pci_enable_sriov
Date: Mon, 8 Dec 2014 20:52:04 +0200 [thread overview]
Message-ID: <20141208185204.GB24790@mtldesk30> (raw)
In-Reply-To: <5484C77D.7060501@redhat.com>
On Sun, Dec 07, 2014 at 04:32:45PM -0500, Don Dutile wrote:
> >
> >Does a one-shot flag suffice? E.g., consider assigning a VF to VM and
> >than shutting down the VM. Assuming this feature is disabled,
> >the VF didn't appear on the hypervisor prior to the assignment but
> >will appear after its shutdown.
> >
> +1 to this question.
> All I see is a one-shot savings in VF configuration time at pci_sriov_enable() time.
> Please explain why this is so important for mlx5 (sriov) operation?
>
This is not a specific mlx5 requirement. The rational is that you
don't want to probe the virtual fucntions at the hypervisor just
because they appear there all of the sudden. You are likely to want to
assign some of them to VMs so why probe them and then remove them? It
makes sense to me that other drivers would also like this kind of
fucntionality.
> Can the vf driver probe be called & exit early the first time, and perform full
> (host) configuration thereafter?
>
Yes, this can be done but I was thinking that other drivers could also
benefit from such functionality.
next prev parent reply other threads:[~2014-12-08 18:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-07 13:08 [PATCH RFC] pci: Control whether VFs are probed on pci_enable_sriov Eli Cohen
2014-12-07 17:05 ` Yuval Mintz
2014-12-07 18:42 ` Eli Cohen
2014-12-07 20:08 ` Yuval Mintz
2014-12-08 19:10 ` Eli Cohen
2014-12-08 19:25 ` Yuval Mintz
2014-12-09 6:43 ` Eli Cohen
2014-12-09 7:07 ` Yuval Mintz
2014-12-09 17:24 ` Don Dutile
2014-12-07 21:32 ` Don Dutile
2014-12-08 18:52 ` Eli Cohen [this message]
2015-01-09 18:25 ` Bjorn Helgaas
2015-01-09 18:38 ` Don Dutile
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141208185204.GB24790@mtldesk30 \
--to=eli@dev.mellanox.co.il \
--cc=Yuval.Mintz@qlogic.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=ddutile@redhat.com \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=yevgenyp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox