From: David Miller <davem@davemloft.net>
To: ogerlitz@mellanox.com
Cc: netdev@vger.kernel.org, matanb@mellanox.com, amirv@mellanox.com,
talal@mellanox.com, jackm@dev.mellanox.co.il
Subject: Re: [PATCH net-next 02/10] net/mlx4_core: Mask out host side virtualization features for guests
Date: Tue, 09 Dec 2014 14:40:46 -0500 (EST) [thread overview]
Message-ID: <20141209.144046.110046237866554513.davem@davemloft.net> (raw)
In-Reply-To: <1417698835-11050-3-git-send-email-ogerlitz@mellanox.com>
From: Or Gerlitz <ogerlitz@mellanox.com>
Date: Thu, 4 Dec 2014 15:13:47 +0200
> @@ -1053,6 +1053,11 @@ int mlx4_QUERY_DEV_CAP_wrapper(struct mlx4_dev *dev, int slave,
> field &= ~0x80;
> MLX4_PUT(outbox->buf, field, QUERY_DEV_CAP_FLOW_STEERING_IPOIB_OFFSET);
>
> + /* turn off host side virt features (VST, FSM, etc) for guests */
> + MLX4_GET(field32, outbox->buf, QUERY_DEV_CAP_EXT_2_FLAGS_OFFSET);
> + field32 &= ~((1 << 26) | (1 << 21) | (1 << 20));
> + MLX4_PUT(outbox->buf, field32, QUERY_DEV_CAP_EXT_2_FLAGS_OFFSET);
> +
Please use mnenomics instead of magic constants for this, thanks.
next prev parent reply other threads:[~2014-12-09 19:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 13:13 [PATCH net-next 00/10] mlx4 driver update Or Gerlitz
2014-12-04 13:13 ` [PATCH net-next 01/10] net/mlx4_en: Set csum level for encapsulated packets Or Gerlitz
2014-12-04 13:13 ` [PATCH net-next 02/10] net/mlx4_core: Mask out host side virtualization features for guests Or Gerlitz
2014-12-09 19:40 ` David Miller [this message]
2014-12-09 20:25 ` Or Gerlitz
2014-12-04 13:13 ` [PATCH net-next 03/10] net/mlx4_core: Use tasklet for user-space CQ completion events Or Gerlitz
2014-12-04 13:13 ` [PATCH net-next 04/10] net/mlx4: Change QP allocation scheme Or Gerlitz
2014-12-04 13:13 ` [PATCH net-next 05/10] net/mlx4: Add a check if there are too many reserved QPs Or Gerlitz
2014-12-04 13:13 ` [PATCH net-next 06/10] net/mlx4: Add mlx4_bitmap zone allocator Or Gerlitz
2014-12-09 19:42 ` David Miller
2014-12-09 20:29 ` Or Gerlitz
2014-12-04 13:13 ` [PATCH net-next 07/10] net/mlx4: Add A0 hybrid steering Or Gerlitz
2014-12-04 13:13 ` [PATCH net-next 08/10] net/mlx4_core: Add explicit error message when rule doesn't meet configuration Or Gerlitz
2014-12-04 13:13 ` [PATCH net-next 09/10] net/mlx4: Refactor QUERY_PORT Or Gerlitz
2014-12-04 13:13 ` [PATCH net-next 10/10] net/mlx4: Add support for A0 steering Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141209.144046.110046237866554513.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amirv@mellanox.com \
--cc=jackm@dev.mellanox.co.il \
--cc=matanb@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=talal@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox