From: David Miller <davem@davemloft.net>
To: mkubecek@suse.cz
Cc: kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] macvlan: allow setting LRO independently of lower device
Date: Tue, 09 Dec 2014 16:00:48 -0500 (EST) [thread overview]
Message-ID: <20141209.160048.1159420484833054299.davem@davemloft.net> (raw)
In-Reply-To: <20141205190937.99BD6A0BB0@unicorn.suse.cz>
From: Michal Kubecek <mkubecek@suse.cz>
Date: Fri, 5 Dec 2014 17:05:49 +0100
> Since commit fbe168ba91f7 ("net: generic dev_disable_lro() stacked
> device handling"), dev_disable_lro() zeroes NETIF_F_LRO feature flag
> first for a macvlan device and then for its lower device. As an attempt
> to set NETIF_F_LRO to zero is ignored, dev_disable_lro() issues a
> warning and taints kernel.
>
> Allowing NETIF_F_LRO to be set independently of the lower device
> consists of three parts:
>
> - add the flag to hw_features to allow toggling it
> - allow setting it to 0 even if lower device has the flag set
> - add the flag to MACVLAN_FEATURES to restore copying from lower
> device on macvlan creation
>
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
Applied, thanks.
prev parent reply other threads:[~2014-12-09 21:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 16:05 [PATCH net-next] macvlan: allow setting LRO independently of lower device Michal Kubecek
2014-12-09 21:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141209.160048.1159420484833054299.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox