From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: dann.frazier@canonical.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] tcp: fix more NULL deref after prequeue changes
Date: Tue, 09 Dec 2014 21:39:49 -0500 (EST) [thread overview]
Message-ID: <20141209.213949.588465548847992235.davem@davemloft.net> (raw)
In-Reply-To: <1418147768.27198.7.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 09 Dec 2014 09:56:08 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> When I cooked commit c3658e8d0f1 ("tcp: fix possible NULL dereference in
> tcp_vX_send_reset()") I missed other spots we could deref a NULL
> skb_dst(skb)
>
> Again, if a socket is provided, we do not need skb_dst() to get a
> pointer to network namespace : sock_net(sk) is good enough.
>
> Reported-by: Dann Frazier <dann.frazier@canonical.com>
> Bisected-by: Dann Frazier <dann.frazier@canonical.com>
> Tested-by: Dann Frazier <dann.frazier@canonical.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Fixes: ca777eff51f7 ("tcp: remove dst refcount false sharing for prequeue mode")
Applied and queued up for 3.18-stable.
prev parent reply other threads:[~2014-12-10 2:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 16:00 [bisect] 3.18 oops in tcp_v4_send_reset() dann frazier
2014-12-09 16:13 ` Daniel Borkmann
2014-12-09 16:16 ` Eric Dumazet
2014-12-09 16:18 ` Eric Dumazet
2014-12-09 16:28 ` Eric Dumazet
2014-12-09 17:10 ` Dann Frazier
2014-12-09 17:23 ` Eric Dumazet
2014-12-09 17:56 ` [PATCH net] tcp: fix more NULL deref after prequeue changes Eric Dumazet
2014-12-10 2:39 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141209.213949.588465548847992235.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dann.frazier@canonical.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox