From: David Miller <davem@davemloft.net>
To: b38611@freescale.com
Cc: netdev@vger.kernel.org, bhutchings@solarflare.com,
stephen@networkplumber.org
Subject: Re: [PATCH net-next 1/3] net: fec: reset fep link status in suspend function
Date: Wed, 10 Dec 2014 14:54:24 -0500 (EST) [thread overview]
Message-ID: <20141210.145424.35618035568083747.davem@davemloft.net> (raw)
In-Reply-To: <1418205289-7730-2-git-send-email-b38611@freescale.com>
From: Fugang Duan <b38611@freescale.com>
Date: Wed, 10 Dec 2014 17:54:47 +0800
> + /*
> + * SOC supply clock to phy, when clock is disabled, phy link down
> + * SOC control phy regulator, when regulator is disabled, phy link down
> + */
Comments in the networking should be of the form:
/* Like
* this.
*/
Not:
/*
* Like
* this.
*/
next prev parent reply other threads:[~2014-12-10 19:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 9:54 [PATCH net-next 0/3] net: fec: driver code clean and bug fix Fugang Duan
2014-12-10 9:54 ` [PATCH net-next 1/3] net: fec: reset fep link status in suspend function Fugang Duan
2014-12-10 19:54 ` David Miller [this message]
2014-12-11 1:40 ` fugang.duan
2014-12-10 9:54 ` [PATCH net-next 2/3] net: fec: clear all interrupt events to support i.MX6SX Fugang Duan
2014-12-10 9:54 ` [PATCH net-next 3/3] net: fec: only enable mdio interrupt before phy device link up Fugang Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141210.145424.35618035568083747.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=b38611@freescale.com \
--cc=bhutchings@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).