From: David Miller <davem@davemloft.net>
To: sergei.shtylyov@cogentembedded.com
Cc: mitsuhiro.kimura.kc@renesas.com, netdev@vger.kernel.org
Subject: Re: errors in alignment changes..
Date: Wed, 10 Dec 2014 20:42:15 -0500 (EST) [thread overview]
Message-ID: <20141210.204215.46146677361631214.davem@davemloft.net> (raw)
In-Reply-To: <5488C447.5080906@cogentembedded.com>
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Thu, 11 Dec 2014 01:08:07 +0300
> I guess we can just do:
>
> rxdesc->addr = dma_map_single(...);
Best not to leave a potentially invalid DMA address in a
receive descriptor the chip can potentially fetch and
look at.
That's why I said to put it into a local variable and
check for errors first.
next prev parent reply other threads:[~2014-12-11 1:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 20:52 errors in alignment changes David Miller
2014-12-10 22:08 ` Sergei Shtylyov
2014-12-11 1:42 ` David Miller [this message]
2014-12-12 4:30 ` Simon Horman
2014-12-12 12:00 ` Sergei Shtylyov
2014-12-16 5:33 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141210.204215.46146677361631214.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=mitsuhiro.kimura.kc@renesas.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).