From: David Miller <davem@davemloft.net>
To: kxie@chelsio.com
Cc: linux-scsi@vger.kernel.org, netdev@vger.kernel.org,
hariprasad@chelsio.com, anish@chelsio.com, hch@infradead.org,
James.Bottomley@HansenPartnership.com, michaelc@cs.wisc.edu
Subject: Re: [PATCH net v8 1/7] cxgb4i: fix tx immediate data credit check
Date: Wed, 10 Dec 2014 22:54:45 -0500 (EST) [thread overview]
Message-ID: <20141210.225445.458745535803327140.davem@davemloft.net> (raw)
In-Reply-To: <201412102111.sBALB6sI011656@localhost6.localdomain6>
From: Karen Xie <kxie@chelsio.com>
Date: Wed, 10 Dec 2014 13:11:06 -0800
> From: Karen Xie <kxie@chelsio.com>
>
> Only data skbs need the wr header added while control skbs do not. Make sure they are treated differently.
>
> Signed-off-by: Karen Xie <kxie@chelsio.com>
Please text format your commit messages to 80 characters or less per
line.
People are going to read your commits using text tools, not
necessarily GUI tools which will auto-format your commit message.
I know this seems like we are being difficult, but you are making many
fundamental mistakes in your efforts to merge in these changes.
next prev parent reply other threads:[~2014-12-11 3:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 21:11 [PATCH net v8 1/7] cxgb4i: fix tx immediate data credit check Karen Xie
2014-12-11 3:54 ` David Miller [this message]
2014-12-11 15:26 ` Karen Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141210.225445.458745535803327140.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=James.Bottomley@HansenPartnership.com \
--cc=anish@chelsio.com \
--cc=hariprasad@chelsio.com \
--cc=hch@infradead.org \
--cc=kxie@chelsio.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).