Re: [PATCH iproute2 0/2] lib names: Refactoring and cleanups

[vadim4j@gmail.com]

On Tue, Dec 09, 2014 at 08:38:56PM -0800, Stephen Hemminger wrote:
> On Sat,  6 Dec 2014 04:05:10 +0200
> Vadim Kochan <vadim4j@gmail.com> wrote:
> 
> > Some cleanups and refactoring in lib/rt_names.c:
> > 
> >     #1 Replaced using of /etc/iproute2 path by CONFDIR define
> >         when initializing tables of group names.
> > 
> >     #2 Added helper to have one func for parsing id and names from
> >         db files.
> > 
> > Vadim Kochan (2):
> >   lib names: Use CONFDIR for specify 'group' file path
> >   lib names: Add helper func for parse id and name from file
> > 
> >  lib/rt_names.c | 70 +++++++++++++++++++++++++++++++++-------------------------
> >  1 file changed, 40 insertions(+), 30 deletions(-)
> > 
> 
> Both applied

Hi Stephen,

I see a warning (after 'make clean && make') about using 'const' in lib/rt_names.c:

    static const char * rtnl_rtscope_tab[256] = {
            "global",
    };

which came with PATCH with a subject:

    "lib names: Add helper func for parse id and name from file" (f00073e8b)

but in the PATCH version which was sent by me in email I did not see this.

Why it was needed ?

Regards,
Vadim