* Multicast packets being lost (3.10 stable)
@ 2014-03-24 16:41 Stephen Hemminger
2014-03-25 13:06 ` Linus Lüssing
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Hemminger @ 2014-03-24 16:41 UTC (permalink / raw)
To: Linus Lüssing, David Miller; +Cc: netdev
We are seeing multicast snooping related issues.
Is there some reason this commit never went into stable (3.10)
commit b00589af3b04736376f24625ab0b394642e89e29
Author: Linus Lüssing <linus.luessing@web.de>
Date: Thu Aug 1 01:06:20 2013 +0200
bridge: disable snooping if there is no querier
If there is no querier on a link then we won't get periodic reports and
therefore won't be able to learn about multicast listeners behind ports,
potentially leading to lost multicast packets, especially for multicast
listeners that joined before the creation of the bridge.
These lost multicast packets can appear since c5c23260594
("bridge: Add multicast_querier toggle and disable queries by default")
in particular.
With this patch we are flooding multicast packets if our querier is
disabled and if we didn't detect any other querier.
A grace period of the Maximum Response Delay of the querier is added to
give multicast responses enough time to arrive and to be learned from
before disabling the flooding behaviour again.
Signed-off-by: Linus Lüssing <linus.luessing@web.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Multicast packets being lost (3.10 stable) 2014-03-24 16:41 Multicast packets being lost (3.10 stable) Stephen Hemminger @ 2014-03-25 13:06 ` Linus Lüssing 2014-09-10 13:33 ` Linus Lüssing 0 siblings, 1 reply; 6+ messages in thread From: Linus Lüssing @ 2014-03-25 13:06 UTC (permalink / raw) To: Stephen Hemminger; +Cc: David Miller, Linus Lüssing, netdev That commit is supposed to be a fix and seems to be a easily cherry-pickable on top of 3.10. So I think it's suitable for stable There are two follow-up commit for this particular patch that I'm aware of: "bridge: separate querier and query timer into IGMP/IPv4 and MLD/IPv6 ones" (cc0fdd80). That's just an optimization and can be ignored for stable. The second one is "bridge: don't try to update timers in case of broken MLD queries" (248ba8ec0). Which is a direct fix for b00589af3 and should therefore go into stable, too, if b00589af3 goes into stable. Cheers, Linus On Mon, Mar 24, 2014 at 09:41:07AM -0700, Stephen Hemminger wrote: > We are seeing multicast snooping related issues. > Is there some reason this commit never went into stable (3.10) > > commit b00589af3b04736376f24625ab0b394642e89e29 > Author: Linus Lüssing <linus.luessing@web.de> > Date: Thu Aug 1 01:06:20 2013 +0200 > > bridge: disable snooping if there is no querier > > If there is no querier on a link then we won't get periodic reports and > therefore won't be able to learn about multicast listeners behind ports, > potentially leading to lost multicast packets, especially for multicast > listeners that joined before the creation of the bridge. > > These lost multicast packets can appear since c5c23260594 > ("bridge: Add multicast_querier toggle and disable queries by default") > in particular. > > With this patch we are flooding multicast packets if our querier is > disabled and if we didn't detect any other querier. > > A grace period of the Maximum Response Delay of the querier is added to > give multicast responses enough time to arrive and to be learned from > before disabling the flooding behaviour again. > > Signed-off-by: Linus Lüssing <linus.luessing@web.de> > Signed-off-by: David S. Miller <davem@davemloft.net> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Multicast packets being lost (3.10 stable) 2014-03-25 13:06 ` Linus Lüssing @ 2014-09-10 13:33 ` Linus Lüssing 2014-12-10 19:16 ` Linus Lüssing 0 siblings, 1 reply; 6+ messages in thread From: Linus Lüssing @ 2014-09-10 13:33 UTC (permalink / raw) To: netdev Cc: openwrt-devel, Greg Kroah-Hartman, bridge, David Miller, Stephen Hemminger I just got a complaint about bridges, multicast and a 3.10 kernel again. Seems like nobody had any objections about queueing these two patches for stable ( 2)+3) )? Also I'm still missing some more fixes in the stable branches. Especially 5), 6) and 7) are of high priority (next to 2) and 3) ) in my opinion as otherwise IPv6 in general could be broken for people using 3.12 or 3.13 (as 3.12 contains a patch which activates multicast snooping for link-local addresses, too: 3c3769e63). Here is a more ordered list of patches I'd suggest to be queued for stable: 1) bridge: fix switched interval for MLD Query types -> 32de868cb (present since 3.10) 2) bridge: disable snooping if there is no querier -> b00589af3 (present since 3.11) 3) bridge: don't try to update timers in case of broken MLD queries -> 248ba8ec0 (present since 3.11) 4) Revert "bridge: only expire the mdb entry when query is received" -> 454594f3b (present since 3.12) 5) bridge: multicast: add sanity check for query source addresses -> 6565b9eee (present since 3.14) 6) bridge: multicast: add sanity check for general query destination -> 9ed973cc4 (present since 3.14) 7) bridge: multicast: enable snooping on general queries only -> 20a599bec (present since 3.14) Let me know what you'd think about that or if there's any trouble applying them to older kernels. Cheers, Linus On Tue, Mar 25, 2014 at 02:06:07PM +0100, Linus Lüssing wrote: > That commit is supposed to be a fix and seems to be a easily > cherry-pickable on top of 3.10. So I think it's suitable for > stable > > There are two follow-up commit for this particular patch that I'm aware > of: "bridge: separate querier and query timer into IGMP/IPv4 > and MLD/IPv6 ones" (cc0fdd80). That's just an optimization > and can be ignored for stable. > > The second one is "bridge: don't try to update timers in case of > broken MLD queries" (248ba8ec0). Which is a direct fix for > b00589af3 and should therefore go into stable, too, if b00589af3 > goes into stable. > > Cheers, Linus > > > On Mon, Mar 24, 2014 at 09:41:07AM -0700, Stephen Hemminger wrote: > > We are seeing multicast snooping related issues. > > Is there some reason this commit never went into stable (3.10) > > > > commit b00589af3b04736376f24625ab0b394642e89e29 > > Author: Linus Lüssing <linus.luessing@web.de> > > Date: Thu Aug 1 01:06:20 2013 +0200 > > > > bridge: disable snooping if there is no querier > > > > If there is no querier on a link then we won't get periodic reports and > > therefore won't be able to learn about multicast listeners behind ports, > > potentially leading to lost multicast packets, especially for multicast > > listeners that joined before the creation of the bridge. > > > > These lost multicast packets can appear since c5c23260594 > > ("bridge: Add multicast_querier toggle and disable queries by default") > > in particular. > > > > With this patch we are flooding multicast packets if our querier is > > disabled and if we didn't detect any other querier. > > > > A grace period of the Maximum Response Delay of the querier is added to > > give multicast responses enough time to arrive and to be learned from > > before disabling the flooding behaviour again. > > > > Signed-off-by: Linus Lüssing <linus.luessing@web.de> > > Signed-off-by: David S. Miller <davem@davemloft.net> _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Multicast packets being lost (3.10 stable) 2014-09-10 13:33 ` Linus Lüssing @ 2014-12-10 19:16 ` Linus Lüssing 2014-12-13 20:37 ` David Miller 0 siblings, 1 reply; 6+ messages in thread From: Linus Lüssing @ 2014-12-10 19:16 UTC (permalink / raw) To: David Miller Cc: Stephen Hemminger, netdev, bridge, Greg Kroah-Hartman, openwrt-devel, David Miller Hi David, did you have a chance to look into backporting these fixes for stable yet? (if I read the docs correctly, I should query you for suggestions for stable kernels, right?) Also, an eighth patch I'd suggest for stable now: 8) bridge: fix netfilter/NF_BR_LOCAL_OUT for own, locally generated queries -> f0b4eeced (since 3.18) If there's anything unclear, just let me know. Thanks :)! Cheers, Linus On Wed, Sep 10, 2014 at 03:33:41PM +0200, Linus Lüssing wrote: > I just got a complaint about bridges, multicast and a > 3.10 kernel again. Seems like nobody had any objections about > queueing these two patches for stable ( 2)+3) )? > > Also I'm still missing some more fixes in the stable branches. > Especially 5), 6) and 7) are of high priority (next to 2) and 3) ) > in my opinion as otherwise IPv6 in general could be broken for people > using 3.12 or 3.13 (as 3.12 contains a patch which activates > multicast snooping for link-local addresses, too: 3c3769e63). > > Here is a more ordered list of patches I'd suggest to be queued for > stable: > > 1) bridge: fix switched interval for MLD Query types > -> 32de868cb (present since 3.10) > 2) bridge: disable snooping if there is no querier > -> b00589af3 (present since 3.11) > 3) bridge: don't try to update timers in case of broken MLD queries > -> 248ba8ec0 (present since 3.11) > 4) Revert "bridge: only expire the mdb entry when query is received" > -> 454594f3b (present since 3.12) > 5) bridge: multicast: add sanity check for query source addresses > -> 6565b9eee (present since 3.14) > 6) bridge: multicast: add sanity check for general query destination > -> 9ed973cc4 (present since 3.14) > 7) bridge: multicast: enable snooping on general queries only > -> 20a599bec (present since 3.14) > > Let me know what you'd think about that or if there's any trouble > applying them to older kernels. > > Cheers, Linus > > > On Tue, Mar 25, 2014 at 02:06:07PM +0100, Linus Lüssing wrote: > > That commit is supposed to be a fix and seems to be a easily > > cherry-pickable on top of 3.10. So I think it's suitable for > > stable > > > > There are two follow-up commit for this particular patch that I'm aware > > of: "bridge: separate querier and query timer into IGMP/IPv4 > > and MLD/IPv6 ones" (cc0fdd80). That's just an optimization > > and can be ignored for stable. > > > > The second one is "bridge: don't try to update timers in case of > > broken MLD queries" (248ba8ec0). Which is a direct fix for > > b00589af3 and should therefore go into stable, too, if b00589af3 > > goes into stable. > > > > Cheers, Linus > > > > > > On Mon, Mar 24, 2014 at 09:41:07AM -0700, Stephen Hemminger wrote: > > > We are seeing multicast snooping related issues. > > > Is there some reason this commit never went into stable (3.10) > > > > > > commit b00589af3b04736376f24625ab0b394642e89e29 > > > Author: Linus Lüssing <linus.luessing@web.de> > > > Date: Thu Aug 1 01:06:20 2013 +0200 > > > > > > bridge: disable snooping if there is no querier > > > > > > If there is no querier on a link then we won't get periodic reports and > > > therefore won't be able to learn about multicast listeners behind ports, > > > potentially leading to lost multicast packets, especially for multicast > > > listeners that joined before the creation of the bridge. > > > > > > These lost multicast packets can appear since c5c23260594 > > > ("bridge: Add multicast_querier toggle and disable queries by default") > > > in particular. > > > > > > With this patch we are flooding multicast packets if our querier is > > > disabled and if we didn't detect any other querier. > > > > > > A grace period of the Maximum Response Delay of the querier is added to > > > give multicast responses enough time to arrive and to be learned from > > > before disabling the flooding behaviour again. > > > > > > Signed-off-by: Linus Lüssing <linus.luessing@web.de> > > > Signed-off-by: David S. Miller <davem@davemloft.net> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Multicast packets being lost (3.10 stable) 2014-12-10 19:16 ` Linus Lüssing @ 2014-12-13 20:37 ` David Miller 2014-12-15 8:04 ` Simon Horman 0 siblings, 1 reply; 6+ messages in thread From: David Miller @ 2014-12-13 20:37 UTC (permalink / raw) To: linus.luessing; +Cc: openwrt-devel, netdev, bridge, gregkh, shemming From: Linus Lüssing <linus.luessing@c0d3.blue> Date: Wed, 10 Dec 2014 20:16:33 +0100 > did you have a chance to look into backporting these fixes for > stable yet? I am not submitting -stable fixes back to 3.10 any longer, at most I am doing 4 -stable releases and right now that is 3.18, 3.17, v3.14, and v3.12 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Multicast packets being lost (3.10 stable) 2014-12-13 20:37 ` David Miller @ 2014-12-15 8:04 ` Simon Horman 0 siblings, 0 replies; 6+ messages in thread From: Simon Horman @ 2014-12-15 8:04 UTC (permalink / raw) To: David Miller Cc: linus.luessing, shemming, netdev, bridge, gregkh, openwrt-devel On Sat, Dec 13, 2014 at 03:37:41PM -0500, David Miller wrote: > From: Linus Lüssing <linus.luessing@c0d3.blue> > Date: Wed, 10 Dec 2014 20:16:33 +0100 > > > did you have a chance to look into backporting these fixes for > > stable yet? > > I am not submitting -stable fixes back to 3.10 any longer, at most > I am doing 4 -stable releases and right now that is 3.18, 3.17, > v3.14, and v3.12 Hi Dave, is there a method for people to get networking -stable fixes into older (longterm) stable releases? Would it be best if people submitted them to -stable themselves? ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-12-15 8:04 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-03-24 16:41 Multicast packets being lost (3.10 stable) Stephen Hemminger 2014-03-25 13:06 ` Linus Lüssing 2014-09-10 13:33 ` Linus Lüssing 2014-12-10 19:16 ` Linus Lüssing 2014-12-13 20:37 ` David Miller 2014-12-15 8:04 ` Simon Horman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).