From: David Miller <davem@davemloft.net>
To: sathya.perla@emulex.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2 net] be2net: Export tunnel offloads only when a VxLAN tunnel is created
Date: Thu, 11 Dec 2014 14:44:31 -0500 (EST) [thread overview]
Message-ID: <20141211.144431.135480686828715510.davem@davemloft.net> (raw)
In-Reply-To: <1418286287-19738-1-git-send-email-sathya.perla@emulex.com>
From: Sathya Perla <sathya.perla@emulex.com>
Date: Thu, 11 Dec 2014 03:24:47 -0500
> From: Sriharsha Basavapatna <sriharsha.basavapatna@emulex.com>
>
> The encapsulated offload flags shouldn't be unconditionally exported
> to the stack. The stack expects offloading to work across all tunnel
> types when those flags are set. This would break other tunnels (like
> GRE) since be2net currently supports tunnel offload for VxLAN only.
>
> Also, with VxLANs Skyhawk-R can offload only 1 UDP dport. If more
> than 1 UDP port is added, we should disable offloads in that case too.
>
> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@emulex.com>
> Signed-off-by: Sathya Perla <sathya.perla@emulex.com>
> ---
>
> v2 changes: fix a bad indentation pointed out by Dave M.
Applied, thanks.
prev parent reply other threads:[~2014-12-11 19:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 8:24 [PATCH v2 net] be2net: Export tunnel offloads only when a VxLAN tunnel is created Sathya Perla
2014-12-11 19:44 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141211.144431.135480686828715510.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sathya.perla@emulex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).