From: Simon Horman <horms@verge.net.au>
To: Tobias Klauser <tklauser@distanz.ch>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] net: ethernet: davicom: Allow to select DM9000 for nios2
Date: Fri, 12 Dec 2014 22:58:16 +0900 [thread overview]
Message-ID: <20141212135810.GA20858@verge.net.au> (raw)
In-Reply-To: <20141212124015.GH16916@distanz.ch>
On Fri, Dec 12, 2014 at 01:40:15PM +0100, Tobias Klauser wrote:
> On 2014-12-12 at 12:28:42 +0100, Simon Horman <horms@verge.net.au> wrote:
> > On Fri, Dec 12, 2014 at 10:21:11AM +0100, Tobias Klauser wrote:
> > > This chip is present on older revisions of the DE2 development kit.
> > >
> > > Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> >
> > I wonder if || COMPILE_TEST should also be added to allow extra build
> > coverage. Is there a specific reason it won't compile more widely?
> >
> > Likewise for your smsc patch.
>
> Good point. I don't think there's a reason for it not being compiled
> more widely. Should I update my patches accordingly or send a separate
> patch?
I'm not the maintainer but a follow-up patch or patches seems reasonable to me.
next prev parent reply other threads:[~2014-12-12 13:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 9:21 [PATCH net] net: ethernet: davicom: Allow to select DM9000 for nios2 Tobias Klauser
2014-12-12 9:49 ` David Laight
2014-12-12 9:57 ` Tobias Klauser
2014-12-12 10:08 ` David Laight
2014-12-12 10:17 ` Tobias Klauser
2014-12-12 11:28 ` Simon Horman
2014-12-12 12:40 ` Tobias Klauser
2014-12-12 13:58 ` Simon Horman [this message]
2014-12-12 16:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141212135810.GA20858@verge.net.au \
--to=horms@verge.net.au \
--cc=netdev@vger.kernel.org \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).