From: Wei Yang <weiyang@linux.vnet.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: weiyang@linux.vnet.ibm.com, David.Laight@ACULAB.COM,
eric.dumazet@gmail.com, netdev@vger.kernel.org,
gideonn@mellanox.com, edumazet@google.com, amirv@mellanox.com
Subject: Re: [PATCH net] net/mlx4_en: correct the endianness of doorbell_qpn on big endian platform
Date: Mon, 15 Dec 2014 09:32:49 +0800 [thread overview]
Message-ID: <20141215013249.GA7341@richard> (raw)
In-Reply-To: <20141213.234320.1607496855879763694.davem@davemloft.net>
On Sat, Dec 13, 2014 at 11:43:20PM -0500, David Miller wrote:
>From: Wei Yang <weiyang@linux.vnet.ibm.com>
>Date: Sat, 13 Dec 2014 11:13:38 +0800
>
>> On Mon, Dec 08, 2014 at 10:42:37PM +0800, Wei Yang wrote:
>> If you prefer this way, I would like to send a new version for this.
>> Is it ok for you?
>
>I'm not so sure. There are implications when using the __raw_*()
>routines.
>
>In particular, using __raw_{read,write}l() also means that the usual
>necessary I/O memory barriers are not being performed.
>
>There are therefore no ordering guarantees between __raw_*() and other
>I/O or memory accesses whatsoever.
Thanks David.
Actually, the last mail is asking David Laight. I am trying to understanding
his comment and Amir told me he was suggesting to use __raw_*() version.
Hmm... this is really a problem found in the v3.18-rc1 and the root cause is
the endianess. I am ok to use any method to fix this problem, even revert it.
Could the maintainer from Mellanox gives me a word?
--
Richard Yang
Help you, Help me
next prev parent reply other threads:[~2014-12-15 1:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-30 2:43 [PATCH net] net/mlx4_en: correct the endianness of doorbell_qpn on big endian platform Wei Yang
2014-11-30 2:52 ` Wei Yang
2014-11-30 19:27 ` Eric Dumazet
2014-12-01 1:29 ` Wei Yang
2014-12-06 5:31 ` David Miller
2014-12-06 5:46 ` Eric Dumazet
2014-12-08 3:12 ` Wei Yang
2014-12-08 10:00 ` David Laight
2014-12-08 14:42 ` Wei Yang
2014-12-13 3:13 ` Wei Yang
2014-12-14 4:43 ` David Miller
2014-12-15 1:32 ` Wei Yang [this message]
2014-12-15 9:59 ` Amir Vadai
2014-12-15 10:00 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141215013249.GA7341@richard \
--to=weiyang@linux.vnet.ibm.com \
--cc=David.Laight@ACULAB.COM \
--cc=amirv@mellanox.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=gideonn@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).