Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dan@dcollins.co.nz
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fixed TPACKET V3 to signal poll when block is closed rather than for every packet
Date: Wed, 17 Dec 2014 23:37:29 -0500 (EST)	[thread overview]
Message-ID: <20141217.233729.323289791259636663.davem@davemloft.net> (raw)
In-Reply-To: <14a5a65c372.fa01df65100787.352762707968323665@dcollins.co.nz>

From: Dan Collins <dan@dcollins.co.nz>
Date: Thu, 18 Dec 2014 12:36:56 +1300


> Make TPACKET_V3 signal poll when block is closed rather than for every packet. Side effect is that poll will be signaled when block retire timer expires which didn't previously happen. Issue was visible when sending packets at a very low frequency such that all blocks are retired before packets are received by TPACKET_V3. This caused avoidable packet loss. The fix ensures that the signal is sent when blocks are closed which covers the normal path where the block is filled as well as the path where the timer expires. The case where a block is filled without moving to the next block (ie. all blocks are full) will still cause poll to be signaled.

Please format your commit messages to 80 column ascii formatted text.

> Signed-off-by: Dan Collins &lt;dan@dcollins.co.nz&gt;

You need real "<" and ">" characters here.

       reply	other threads:[~2014-12-18  4:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <14a5a65c372.fa01df65100787.352762707968323665@dcollins.co.nz>
2014-12-18  4:37 ` David Miller [this message]
2014-12-18 21:49 [PATCH] Fixed TPACKET V3 to signal poll when block is closed rather than for every packet Dan Collins
2014-12-18 21:51 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141217.233729.323289791259636663.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dan@dcollins.co.nz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox